More collection item editor options #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mEditorOptions, use auto-properties
…ubfunctions for readability Added OptionsAttribute getting and passing through to CollectionItemPropertyDrawer CollectionItemPropertyDrawer to allow for OptionsAttribute to be provided in constructor
…Utility.SetFoldoutOpen parameters
…s that Match, as inherited & generic types had some edge cases causing invalid casts
brunomikoski
approved these changes
Sep 3, 2021
Owner
|
Nice work! :) Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add shouldDrawGotoButton and shouldDrawPreviewButton to CollectionItemEditorOptions, use auto-properties
Added OptionsAttribute getting and passing through to CollectionItemPropertyDrawer
Changed CollectionItemPropertyDrawer to allow for OptionsAttribute to be provided in constructor
Refactored CollectionItemIndirectReferencePropertyDrawer OnGUI into subfunctions for readability
Change DrawGotoButton to use the same parameters as DrawEditFoldoutButton
Renamed CollectionItemItemPropertyDrawer to CollectionItemPropertyDrawer
Unrelated to Expanded Options: