Skip to content

Support templates#36

Closed
Dieterbe wants to merge 3 commits intobrutasse:masterfrom
Dieterbe:support-templates
Closed

Support templates#36
Dieterbe wants to merge 3 commits intobrutasse:masterfrom
Dieterbe:support-templates

Conversation

@Dieterbe
Copy link
Copy Markdown
Contributor

includes previous PR's (cache and statsd objects), but this is cherrypickable.

@yml
Copy link
Copy Markdown

yml commented Aug 18, 2014

Blind guess since I have not looked at the code in details but the error in travis seems to comes from the fact that ConfigParser has been renamed in python 3.

Something like this might help:

try:
    import configparser
except:
    from six.moves import configparser

@Dieterbe
Copy link
Copy Markdown
Contributor Author

actually i believe importing configparser in py3 should work, in py2 it's ConfigParser.
do we need an external module like six?

@brutasse
Copy link
Copy Markdown
Owner

configparser doesn't have the same API in python2 and python3 so it's not as simple as changing ConfigParser to configparser. I'd rather have templates configuration directly in a templates section in the main yaml file… It's annoying not to have it with the same syntax as graphite-web but it's also annoying to have 2 config files in different formats.

@Dieterbe
Copy link
Copy Markdown
Contributor Author

ok so this PR is no good then

@Dieterbe Dieterbe closed this Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants