New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support templates #36

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Dieterbe
Contributor

Dieterbe commented Jul 16, 2014

includes previous PR's (cache and statsd objects), but this is cherrypickable.

@yml

This comment has been minimized.

Show comment
Hide comment
@yml

yml Aug 18, 2014

Blind guess since I have not looked at the code in details but the error in travis seems to comes from the fact that ConfigParser has been renamed in python 3.

Something like this might help:

try:
    import configparser
except:
    from six.moves import configparser

yml commented Aug 18, 2014

Blind guess since I have not looked at the code in details but the error in travis seems to comes from the fact that ConfigParser has been renamed in python 3.

Something like this might help:

try:
    import configparser
except:
    from six.moves import configparser
@Dieterbe

This comment has been minimized.

Show comment
Hide comment
@Dieterbe

Dieterbe Aug 19, 2014

Contributor

actually i believe importing configparser in py3 should work, in py2 it's ConfigParser.
do we need an external module like six?

Contributor

Dieterbe commented Aug 19, 2014

actually i believe importing configparser in py3 should work, in py2 it's ConfigParser.
do we need an external module like six?

@brutasse

This comment has been minimized.

Show comment
Hide comment
@brutasse

brutasse Aug 22, 2014

Owner

configparser doesn't have the same API in python2 and python3 so it's not as simple as changing ConfigParser to configparser. I'd rather have templates configuration directly in a templates section in the main yaml file… It's annoying not to have it with the same syntax as graphite-web but it's also annoying to have 2 config files in different formats.

Owner

brutasse commented Aug 22, 2014

configparser doesn't have the same API in python2 and python3 so it's not as simple as changing ConfigParser to configparser. I'd rather have templates configuration directly in a templates section in the main yaml file… It's annoying not to have it with the same syntax as graphite-web but it's also annoying to have 2 config files in different formats.

@Dieterbe

This comment has been minimized.

Show comment
Hide comment
@Dieterbe

Dieterbe Aug 28, 2014

Contributor

ok so this PR is no good then

Contributor

Dieterbe commented Aug 28, 2014

ok so this PR is no good then

@Dieterbe Dieterbe closed this Aug 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment