Support templates#36
Closed
Dieterbe wants to merge 3 commits intobrutasse:masterfrom
Closed
Conversation
|
Blind guess since I have not looked at the code in details but the error in travis seems to comes from the fact that ConfigParser has been renamed in python 3. Something like this might help: |
Contributor
Author
|
actually i believe importing configparser in py3 should work, in py2 it's ConfigParser. |
Owner
|
configparser doesn't have the same API in python2 and python3 so it's not as simple as changing |
Contributor
Author
|
ok so this PR is no good then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes previous PR's (cache and statsd objects), but this is cherrypickable.