Simplify Makima system config and add Microsoft Teams/Outlook - #4
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds Microsoft Teams and Outlook Homebrew cask packages with a new Darwin apps.internet module, updates flake.nix's makima username, reconfigures the makima host's app enablement and adds extensive macOS system.defaults/CustomUserPreferences settings, and trims disabled app toggles in NB2123 configs. ChangesMicrosoft Teams/Outlook packages and module
Host configuration updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)Not applicable — this PR consists of declarative Nix configuration changes and static package definitions without multi-component runtime interaction flows. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hosts/makima/default.nix`:
- Around line 36-39: The configuration block is using the wrong option
namespace, so update the `darwin.internet` assignment in `default.nix` to the
existing `darwin.apps.internet` path. Keep the `microsoft-teams.enable` and
`microsoft-outlook.enable` settings under the `darwin.apps.internet` attrset so
the `internet` module resolves correctly and evaluation succeeds.
- Line 103: The screenshot location in the screencapture defaults setup uses a
tilde path, which will not be expanded by macOS. Update the configuration in the
screencapture location setting to use an absolute path, and ensure the target
screenshots directory is created or otherwise guaranteed to exist when this host
config is applied.
In `@modules/darwin/apps/internet.nix`:
- Around line 9-16: The host config is referencing the wrong options namespace,
so the internet app toggles are never applied. Update the
`hosts/makima/default.nix` references to use the declared
`darwin.apps.internet.*` path that is defined by the `darwin.apps.internet`
module, and ensure the `microsoft-teams.enable` and `microsoft-outlook.enable`
settings point to that namespace consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 87ef0384-4744-4891-87eb-715913ae8519
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
flake.nixhosts/NB2123/default.nixhosts/NB2123/home.nixhosts/makima/default.nixhosts/makima/home.nixmodules/darwin/apps/default.nixmodules/darwin/apps/internet.nixpkgs/default.nixpkgs/microsoft-outlook/default.nixpkgs/microsoft-teams/default.nix
Summary by CodeRabbit