Conversation
Parse server response body to extract actual error messages instead of showing generic HTTP status codes. This provides clearer feedback when jobs are cancelled, failed, or otherwise unavailable. Changes: - Add JSON error response parsing in cat command - Add JSON error response parsing in submit command - Show actual error message from server when available - Fall back to showing response body if JSON parsing fails - Import encoding/json and io packages Example before: Error: failed to get job output: HTTP 400 Example after: Error: failed to get job output: job was cancelled
Code ReviewBug: Response body read after close in submit.go Line 223: Fix: move if outputResp.StatusCode != 200 {
defer outputResp.Body.Close()
body, err := io.ReadAll(outputResp.Body)
// ... rest of error handling
}Duplication Error parsing logic is duplicated in cat.go:103-115 and submit.go:221-236. Extract to a helper function to reduce repetition and ensure consistent error handling across commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse server response body to extract actual error messages instead of showing generic HTTP status codes. Provides clearer feedback when jobs are cancelled, failed, or otherwise unavailable.
Changes
catcommandsubmitcommandencoding/jsonandiopackagesExample
Before
After
Implementation
When receiving non-200 status from
GetJobOutput:{"error": "message"}formatFixes #131