Skip to content

Feat/api extension #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 20, 2024
Merged

Feat/api extension #56

merged 37 commits into from
Oct 20, 2024

Conversation

@rohenaz
Copy link
Collaborator

@rohenaz rohenaz commented Oct 18, 2024 •
edited
Loading

  • merge feat: api adjustments - extension methods to use sdk easier #55
    • rename several methods aligning with ts sdk and keeping consistent naming conventions
    • add convenience functions for scripts like script.Address(), script.Addresses() and script.PubKey() and script.Chunks()
    • add transaction.merkletreeparent.go helpers, and update some methods to use these.
  • add spv.Verify() and spv.VerifyScripts()
  • add example for spv.Verify()
  • add whatsonchain chain tracker
  • add tests for new code
  • update change log documented all changes

wregulski and others added 26 commits October 17, 2024 09:16
@wregulski
feat: add merkletreeparent util functions
6bb8110
@wregulski
fix: proper comment for DecodeScriptHex function
4178516
@wregulski
fix: remove unused const fieldOverflowBits
f5bc7a0
@wregulski
fix: proper loop on totalKeyShares function
6ed7ab7
@wregulski
feat: add extension method to return signature as encoded string
5cc21f5
@wregulski
feat: add helper methods to work on decoded script
d18278d
@wregulski
test: tests for newly provided methods on script struct
8e6175e
@wregulski
fix: reformatted comments to be one liners
c0cb4f3
@wregulski
fix: performance upgrade for merkletree utils methods
ef522df
@wregulski
fix: resolve performance issues for MerkleTreeParentBytes
d44961e
@wregulski
fix: shorten comment on MerkleTreeParentStr to pass linter
df67deb
@wregulski
Revert "fix: proper loop on totalKeyShares function"
68e8b12 
This reverts commit 6ed7ab7.
@rohenaz
Merge pull request #55 from wregulski/feat/api-extension
b30eeef 
feat: api adjustments - extension methods to use sdk easier
@shruggr
renames for consistency
f5aee91
@shruggr
remove commented out code
8b1d70d
@shruggr
rename test
958954a
@shruggr
script.Address()
29c34cb
@rohenaz
update changelog
392572b
@shruggr
Merge pull request #54 from wregulski/fix/minor_polishing
07e73b2 
fix: minor polishing - found when implementing it in SPV-Wallet
@shruggr
Merge pull request #53 from wregulski/feat/merkletree-package
ce13b00 
feat: add merkletreeparent util functions
@shruggr
swap names of MerkleTreeParent and MerkleTreeParentBytes
8d865f1
@shruggr
update merklepath to use merkletreeparent
cb7bd65
@rohenaz
add tests, update changelog
62f3122
@rohenaz
update test sgn message string helper
baad705
@rohenaz
test script addresses
6daa0c6
@rohenaz
add script helper tests
3a5dcee
@rohenaz rohenaz marked this pull request as draft October 18, 2024 16:23
@rohenaz rohenaz marked this pull request as ready for review October 20, 2024 13:25
@rohenaz rohenaz merged commit 6eaa007 into master Oct 20, 2024
3 checks passed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rohenaz @wregulski @shruggr