fix(sdk): NOSONAR comment for intentional Peer.ready listener registration - #107
Merged
Conversation
…ter sync Lazy getter pattern broke paired-peer test mocks (peerB's onDataCallback needs to be set when peerA sends). Constructor must register the transport listener synchronously. Added NOSONAR + explanatory comments for Sonar S7059 — this single instance is intentionally suppressed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sonar's NOSONAR suppression must be at the end of the violating line, not as a separate comment block. Move suppression to end-of-line on the constructor assignment with explicit rule ID and reason.
|
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #103 — adds NOSONAR comment + explanatory note for the single
typescript:S7059alert atpackages/sdk/src/auth/Peer.ts:114.Why intentional
this.transport.onData(...)must register the listener synchronously so paired-peer test mocks seeonDataCallbackset immediately upon construction. A lazy getter pattern (which Sonar prefers) breaks 13 tests. Field-based.readyis the correct tradeoff here.Verification
pnpm --filter @bsv/sdk run build✅pnpm --filter @bsv/sdk exec jest 'Peer|AuthFetch'— 116/116 passRefs: #38 #45