ci(sonar): exclude tests from duplication via .sonarcloud.properties - #202
Merged
Conversation
SonarCloud Automatic Analysis reads .sonarcloud.properties, not sonar-project.properties, so the cpd.exclusions added there had no effect. Add the file with sonar.cpd.exclusions covering test files: parallel test suites (DB vs IndexedDB variants) legitimately duplicate large blocks, which was failing the new-code duplication gate on PRs that merely touch them (#197). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SonarCloud here runs Automatic Analysis, which reads
.sonarcloud.properties— notsonar-project.properties. Thesonar.cpd.exclusionsadded tosonar-project.propertiesin #200 therefore had no effect, and pre-existing test-file duplication kept failing thenew_duplicated_lines_densitygate on PRs that merely touch those files (e.g. #197).Changes
.sonarcloud.propertieswithsonar.cpd.exclusionscovering test files (**/*.test.ts,**/test/**, etc.) and*.vectors.ts. Parallel test suites (SQLite vs IndexedDB variants) legitimately duplicate large blocks; tests are already excluded from sources/coverage analysis. Source-code duplication is still fully analyzed.Test plan