fix(security): harden service request boundaries - #327
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ty-everett
marked this pull request as ready for review
July 25, 2026 08:05
ty-everett
requested review from
BraydenLangley,
sirdeggen and
tonesnotes
as code owners
July 25, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Wave 2 of the repository health program in #324 hardens three service boundaries that currently produce CodeQL findings:
The UHRP MIME detector now shares the same runtime CDN root as uploads and the service's
express.static('public')mount, avoiding the former source-vs-compiled__dirnamemismatch.CodeQL #120 is intentionally not claimed here. The existing authenticated limiter runs after authentication, so the authentication middleware itself remains unbounded. That finding belongs in the next shared pre-auth and post-auth rate-limiting wave with the related service alerts.
Security end state
wx, so an existing file or symlink cannot be followed or overwrittenVerification
394c9327d: all CI lanes green, no CodeQL PR alerts, Sonar quality gate passed with zero issues/hotspots and A ratings; the follow-up commit adds LCOV ingestion to replace Sonar's initial 0% new-code-coverage resultNo package versions are changed or published by this PR.