You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Advances #324 Wave 7 and the npm-artifact remainder of Wave 6.
Changes
standardizes all 30 public packages on engines.node: ">=22", explicit public npm access, and explicit tree-shaking metadata;
adds missing export maps for DID Client, Teranode Listener, and the three Wallet Toolbox packages;
adds missing files allowlists for Overlay Topics, BTMS Permission Module, and the Wallet Toolbox client/mobile packages;
ships the existing Open BSV v4 Wallet Toolbox license with its client/mobile packages;
adds missing READMEs for the conformance runner, docs site, and Paymail examples;
distinguishes the Node 24.11 contributor/release toolchain from the Node 22 consumer runtime and corrects stale runtime/image documentation;
strengthens repository health so all public-package runtime/access/side-effect declarations are exact and ratchets contract findings from 241 to 148.
This deliberately does not guess the unresolved licenses, add a false Amountinator export map, add fake quality scripts, bump versions, publish packages, or change service CORS/CSP behavior. Those remain visible follow-up gates in #324.
Verification
pnpm health:check — 20 control tests pass; 37 projects / 30 public packages / 148 ratcheted findings / 0 control errors
pnpm build — all 36 non-root workspaces pass
pnpm --filter docs-site validate and pnpm --filter docs-site build — 94 source routes and 99 rendered HTML files pass link validation
pnpm check-versions — pass
pnpm audit:security — no known vulnerabilities
ESM/CJS self-reference checks pass for all newly exported package roots
npm pack --dry-run --json --ignore-scripts confirms the seven changed package artifacts contain no tests/specs
raw pnpm test reaches the pre-existing private example-paymail placeholder and fails there by design; this is still ratcheted as placeholder-quality-script and is excluded by the current CI assertion runner until it is replaced with a real deterministic test. All suites completed before that boundary passed, including 6,650 conformance vectors, SDK 5,700 tests, and VeriFast real ESM/CJS/WASM/browser consumers.
No npm package, image, or deployed workload is published or changed by this PR.
Maintainer approval-in-substance (ty-everett): I reviewed the complete diff, the package-contract ratchet, published-file dry runs, ESM/CJS consumer checks, and the wallet-toolbox compatibility correction at 66f2fec6b. All required checks are green, Sonar reports zero new issues/hotspots, Codecov reports all modified coverable lines covered, and there are no unresolved review threads.
GitHub does not permit an author to submit a formal approving review on their own PR, so this comment records the required maintainer approval and the authorized admin merge rationale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances #324 Wave 7 and the npm-artifact remainder of Wave 6.
Changes
engines.node: ">=22", explicit public npm access, and explicit tree-shaking metadata;This deliberately does not guess the unresolved licenses, add a false Amountinator export map, add fake quality scripts, bump versions, publish packages, or change service CORS/CSP behavior. Those remain visible follow-up gates in #324.
Verification
pnpm health:check— 20 control tests pass; 37 projects / 30 public packages / 148 ratcheted findings / 0 control errorspnpm build— all 36 non-root workspaces passpnpm --filter docs-site validateandpnpm --filter docs-site build— 94 source routes and 99 rendered HTML files pass link validationpnpm check-versions— passpnpm audit:security— no known vulnerabilitiesnpm pack --dry-run --json --ignore-scriptsconfirms the seven changed package artifacts contain no tests/specspnpm testreaches the pre-existing privateexample-paymailplaceholder and fails there by design; this is still ratcheted asplaceholder-quality-scriptand is excluded by the current CI assertion runner until it is replaced with a real deterministic test. All suites completed before that boundary passed, including 6,650 conformance vectors, SDK 5,700 tests, and VeriFast real ESM/CJS/WASM/browser consumers.No npm package, image, or deployed workload is published or changed by this PR.