You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
converts @bsv/fund-wallet into a tested CLI-only ESM package with strict input validation, zero-warning lint, coverage, and an installed-bin tarball check
converts @bsv/402-pay to matched ESM/CommonJS root, server, and client entry points with strict declarations and clean-consumer artifact checks
pnpm codegen:check completed the TypeScript generator but the local Python leg could not start because uv is not installed on this Mac; hosted CI is authoritative for that check.
No package versions, npm tags, or releases are changed by this PR.
Maintainer approval-in-substance by ty-everett for exact head 4161470a390d307235c4d5afe591b0864607a14a.
I reviewed the implementation and verification evidence and approve this change for admin merge. GitHub does not permit a pull request author to submit a formal APPROVE review on their own PR, so this comment records the requested maintainer approval without waiting for another reviewer.
Verified on this exact head:
all GitHub Actions, CodeQL, Socket, SonarCloud, conformance, artifact, test, coverage, and merge-gate checks pass;
SonarCloud: 0 open/confirmed issues and 0 security hotspots;
Codecov: 95.0% patch coverage; repository coverage increases from 67.91% to 68.04%;
no unresolved review threads or requested reviewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #324.
Summary
@bsv/fund-walletinto a tested CLI-only ESM package with strict input validation, zero-warning lint, coverage, and an installed-bin tarball check@bsv/402-payto matched ESM/CommonJS root, server, and client entry points with strict declarations and clean-consumer artifact checksLocal evidence
pnpm install --frozen-lockfile --ignore-scriptspnpm buildpnpm test(all 36 non-root projects passed)pnpm lintpnpm docs:build(95 routes, 100 HTML files/link checked)pnpm audit:security(no known vulnerabilities)pnpm check-versionspnpm health:check(108 findings, 0 control errors)pnpm license:pack-check(30/30 public tarballs)@bsv/402-pay: 105 tests, 100% statements/branches/functions/lines; strict ESM/CJS tarball consumers pass@bsv/fund-wallet: 12 tests, 92.23% lines and 93.15% branches; installedfund-metanet --helptarball consumer passespnpm codegen:checkcompleted the TypeScript generator but the local Python leg could not start becauseuvis not installed on this Mac; hosted CI is authoritative for that check.No package versions, npm tags, or releases are changed by this PR.