Standardize wallet platform builds and Open BSV licensing - #351
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
83649a5 to
0d42b85
Compare
0d42b85 to
1e0c7d6
Compare
|
|
Maintainer approval-in-substance ( I reviewed the full diff and all final-head evidence. The complete build/test/coverage/platform matrix, merge gate, CodeQL (Actions and JavaScript/TypeScript), dependency review, Socket, SonarCloud, repository health, docs, conformance, package/tarball licensing, and security audit are green. SonarCloud reports 0 open issues and 0 security hotspots; Codecov reports all modified and coverable lines are covered; there are no unresolved review threads. I approve this exact head for squash merge. GitHub does not permit the PR author to submit a formal approving review, so this exact-head maintainer record is the approval artifact and the merge will use the authorized admin path without waiting for unrelated requested reviewers. |



Closes the wallet browser/mobile platform-profile portion of #324 and completes the remaining first-party Open BSV licensing consistency work.
What changed
sideEffects: false, and complete health-profile scripts.@bsv/sdkplus the wallet package, install into a clean project, and validate:require('node:crypto')fallbacks from SDK browser/mobile paths while retaining Web Crypto and the guarded Node 22+process.getBuiltinModulefallback.cumulative,BlockHeaderpredicate, andchainWork).*.man.test.tsconvention so normal CI remains deterministic without deleting live coverage.StorageKnexquery-builder type regression present on currentmainafter fix: align consensus verification and optimize large-data paths #349.Consumer impact
The browser and mobile packages now have stable import/require contracts that are verified as installed tarballs in their actual target toolchains. Bundle-size regressions, server-module leakage, broken source maps, missing declarations, and platform-incompatible SDK syntax will fail CI before release.
No package versions are changed and no npm release is performed in this PR.
Validation
pnpm install --frozen-lockfile --ignore-scriptspnpm buildacross 37 projects; 100 documentation HTML files/link graph validatedpnpm testbefore rebase; exact-main SDK: 144 suites / 5,707 passed; wallet: 143 suites / 1,281 passedpnpm audit:security: no known vulnerabilitiespnpm health:check: 37 projects, 30 public packages, 94 findings, 11 active exceptions, 0 errorspnpm license:check: 46 manifests/copies on Open BSV License Version 6pnpm license:pack-check: 30 public tarballs carry canonicalLICENSE.txt