chore: enforce stack documentation and package coherence - #374
Conversation
d12291d to
038b7a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
038b7a3 to
9c820ac
Compare
9c820ac to
4430114
Compare
|
ty-everett
left a comment
There was a problem hiding this comment.
Admin exact-head review complete for 4430114 (tree 540edf37564ef5e0320c2ee4abfd49a15af4d4b4). GitHub does not permit the PR author to submit a formal APPROVE review, so this records the substantive sign-off before an admin merge. Deployment-impact review found no route, wire, persistence, CORS/CSP, image, manifest, or release change; public services remain public/configurable by default. Wallet Storage fails closed only when authentication is absent, invalid, or mismatched, with explicit regressions. All 64 reported checks pass; exact Codecov is 21/21 changed lines (100%, zero misses/partials); Sonar is 0 issues/0 hotspots; CodeQL, dependency review, Socket, artifacts, docs, conformance, coverage, mutation, browser/mobile, infrastructure image scans, and merge gate pass. No review threads remain.



Purpose
Advance the non-QA documentation, release-operations, package-boundary, and Sonar new-code program in #324 with enforced, source-derived facts rather than another point-in-time audit.
This is intentionally a broad coherence wave: current package, runtime, conformance, documentation, security, and release claims now agree, and CI prevents the same drift from returning.
What changes
Generated facts and documentation governance
docs/reference/stack-facts.mdfrom the governed 37-project inventory, 30 public package manifests, seven standalone infrastructure manifests, and conformance metadata.conformance/PARITY_MATRIX.jsonclassifications and validate 74 files / 6,650 vectors.create-bsv-app,@bsv/auth,@bsv/verifast,@bsv/wallet-toolbox-client, and@bsv/wallet-toolbox-mobile.Executable consumer documentation
workspace:runtime closure, pack those exact sources once, install in a clean temporary consumer with lifecycle scripts disabled, and compile with strict native TypeScript 7 andskipLibCheck: false.Package/declaration correctness
WindowCWISubstratedeclarations with canonicalWalletInterfacetypes; delegated implementation and wire behavior are unchanged.@types/expressfor the six public packages whose declarations expose Express types; governance rejects missing type/runtime pairs.string | string[], and authenticated RPC identity is validated explicitly. Missing/empty/unknownidentity fails closed; ordinary authenticated requests and wire results are unchanged.@bsv/sdk2.2.1,@bsv/paymail2.4.3,@bsv/auth-express-middleware2.1.3,@bsv/payment-express-middleware2.1.2,@bsv/overlay-express2.4.3,@bsv/wallet-relay0.2.3, and wallet toolbox/core/client/mobile 2.4.5.Sonar new-code remediation
Superseded exact heads exposed nine Sonar findings in total. All were treated as actionable and removed rather than dismissed:
String.rawfor intentional backslashes; andRegExp.exec()instead ofString.match()for the final bounded example identifier check.The superseded failed Sonar result is not merge evidence. The exact reviewed head reports zero open new-code issues and zero security hotspots.
Public-service and deployed-impact assessment
Validation
Exact reviewed head:
443011429507eb4d2306f210963f42d7dcb4b9c1(tree540edf37564ef5e0320c2ee4abfd49a15af4d4b4).git diff --checkpassed.Superseded CI iterations caught a no-install generator dependency, clean Express 5 assumptions, nine Sonar findings, and two partially covered authentication branches. All were reproduced or inspected, fixed, and covered. The exact reviewed head passed all 64 reported checks, including 56 CI jobs, both CodeQL languages, Codegen, Conformance, Sonar, Socket, and the merge gate. A prior-head Message Box image build timed out against Docker Hub after its build, lint, and 95 tests passed; the failed-job rerun completed the image build, vulnerability scan, and merge gate, and the final exact head then passed Message Box without retry.
Deliberate exclusions
codex/stack-wide-fuzzingand is not merged here.Closes no tracker item until this exact head and resulting
mainare green and recorded in #324.