Skip to content

Wave 39: centralize contributor and agent governance - #403

Merged
ty-everett merged 2 commits into
mainfrom
codex/contributor-agent-doctrine
Jul 30, 2026
Merged

Wave 39: centralize contributor and agent governance#403
ty-everett merged 2 commits into
mainfrom
codex/contributor-agent-doctrine

Conversation

@ty-everett

@ty-everett ty-everett commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Local and hosted validation are complete on the exact head. Every applicable check is terminal and successful; there are no unresolved findings or review threads.

Program and scope

Impact

  • No public package source or manifest changed
  • Public package source or manifest changed; affected packages are listed below
  • Infrastructure source, dependency, image, or deployment configuration changed
  • Public API, exports, types, runtime targets, or browser/mobile behavior changed
  • Security-sensitive boundary changed
  • Documentation or examples changed

Affected package candidates (not published here): @bsv/sdk 2.2.15, @bsv/templates 1.9.6, and lockstep @bsv/wallet-toolbox, @bsv/wallet-toolbox-client, and @bsv/wallet-toolbox-mobile 2.4.20. Changes are README/contribution-policy alignment only; runtime behavior is unchanged.

Verification

  • Local commands and results: pnpm health:check (113/113 governance tests; 0 findings/control errors), pnpm lint (0 warnings), pnpm format:check, pnpm typecheck, pnpm build, pnpm test, pnpm audit:security (0 vulnerabilities), pnpm check-versions, pnpm docs:facts:check, pnpm docs:build, contributor-policy tests (5/5), issue-form YAML parse, and affected artifact checks all passed
  • Hosted CI run: CI 30568657089 completed successfully with 59 jobs; all exact-head PR checks are terminal and green
  • Conformance evidence: parity generator verifies 74 files / 6,650 vectors; hosted conformance passed; no protocol behavior changed
  • Coverage delta: Codecov patch passed and reports every modified coverable line covered; aggregate SDK, VeriFast, DID, Wallet Toolbox, and other affected-package coverage passed
  • Lint/typecheck delta: zero warnings; all governed TypeScript profiles pass
  • Browser/mobile/packed-consumer evidence: exact tarball contracts and hosted browser/mobile/platform jobs pass for all affected package candidates; behavior is unchanged
  • Performance or bundle-size delta: no runtime source or dependency change; measured impact is zero
  • I self-reviewed the complete diff for correctness, security, compatibility, public API, artifacts, dependencies, docs, and operations
  • All applicable checks are terminal and successful on the exact head; the empty non-coverage package partition was an expected scope skip validated by merge-gate

Security and dependencies

  • No dependency or lockfile change
  • Changelog, runtime relevance, peer compatibility, transitive graph, and audit results were reviewed; the only Dependabot edit clarifies existing major-migration governance
  • CodeQL/negative-test evidence is not applicable because no trust boundary or runtime behavior changed; exact-head CodeQL still passed
  • The exact-head CodeQL analysis has no new alert
  • The exact-head repository quality gate reports zero new Sonar findings (including accepted or false-positive issue states) and zero unreviewed hotspots; both the repository gate and Sonar report passed
  • No new override, advisory dismissal, quality suppression, or skipped test
  • Any temporary exception is registered with owner, evidence, review date, and removal condition; none is introduced here
  • Workflow permissions and lifecycle-script behavior remain least privilege

Dependency evidence

  • Release notes and necessity: no dependency release; a comment now requires dedicated review for database majors
  • Runtime, build, and peer compatibility: no dependency graph or runtime change
  • Deduplicated lockfile: unchanged; frozen install passed
  • Audit and CodeQL: local security audit is clean; exact-head Actions and JavaScript/TypeScript CodeQL passed
  • Package and consumer tests: full workspace tests/build, five exact-package artifact checks, browser/mobile platform jobs, coverage, and mutation quality passed
  • Bundle and performance impact: No runtime source, dependency, bundle, or performance path changed; measured impact is zero.
  • Affected public package versions: SDK 2.2.15; templates 1.9.6; Wallet Toolbox family 2.4.20

Release and operations

  • No npm publication was performed from a workstation or from this PR
  • Required npm patch bumps are included
  • Image/SBOM/provenance/deployment/rollback impact is documented: no image or deployment change; root protected release controls remain authoritative
  • Documentation, changelog, migration, and operational guidance are current

Completion evidence

Consolidation inventory

  • 43 governed package/service scopes now contain generated root-policy pointers
  • 31 legacy agent guides were deliberately consolidated, with stale duplicated technical inventories retired in favor of current READMEs/docs/specs/operator authorities
  • 49 historical nested .github files have explicit root replacement or retirement dispositions
  • 8 package-local contribution/code-of-conduct files were consolidated
  • CI now rejects missing/drifting pointers, nested GitHub ownership, or new package-local contributor policies

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ty-everett ty-everett left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head maintainer self-review completed as ty-everett at fcda716e370b0e3ab4b870ec2be93d5a2b38a771. GitHub does not permit an author to submit an APPROVE review on their own PR, so this anchored review records the required assessment without waiting for another maintainer. The complete diff preserves public API/runtime behavior, centralizes contributor and agent authority, records every historical disposition, and is supported by terminal-successful repository health, lint, formatting, build, typecheck, tests, artifacts, docs, conformance, coverage, patch coverage, mutation, CodeQL, Sonar zero-finding, Socket, container, browser/mobile, and merge-gate evidence. No review threads or requested changes remain.

@ty-everett
ty-everett merged commit 307ba5f into main Jul 30, 2026
75 checks passed
@ty-everett
ty-everett deleted the codex/contributor-agent-doctrine branch July 30, 2026 18:14
sirdeggen added a commit that referenced this pull request Jul 30, 2026
Wave 39 (#403) landed after this branch was cut and now requires a generated
root-policy pointer at every governed project, so add
packages/helpers/air-gap/AGENTS.md and bump the scoped-pointer count to 44.

Also clears the ten new SonarCloud findings the zero-findings gate reported:

- S8786 in src/base64url.ts and tests/helpers.ts — `=+$` backtracks
  super-linearly on a long run of '='. btoa pads to a multiple of four, so a
  bounded `={0,2}$` strips the same padding in linear time.
- S7749 in src/constants.ts — uneven numeric separator groups in
  `0x1_0000_0000`; `2 ** 32` states the u32 bound directly.
- S5906 across four test files — `toHaveLength` reports better than comparing
  a raw `.length`.

No behavior change: the frozen conformance vectors and all 100 tests pass
unchanged, src coverage stays at 100%, and the mutation score is 89.77%.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sirdeggen added a commit that referenced this pull request Jul 30, 2026
Wave 39 (#403) landed after this branch was cut and now requires a generated
root-policy pointer at every governed project, so add
packages/helpers/air-gap/AGENTS.md and bump the scoped-pointer count to 44.

Also clears the ten new SonarCloud findings the zero-findings gate reported:

- S8786 in src/base64url.ts and tests/helpers.ts — `=+$` backtracks
  super-linearly on a long run of '='. btoa pads to a multiple of four, so a
  bounded `={0,2}$` strips the same padding in linear time.
- S7749 in src/constants.ts — uneven numeric separator groups in
  `0x1_0000_0000`; `2 ** 32` states the u32 bound directly.
- S5906 across four test files — `toHaveLength` reports better than comparing
  a raw `.length`.

No behavior change: the frozen conformance vectors and all 100 tests pass
unchanged, src coverage stays at 100%, and the mutation score is 89.77%.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sirdeggen added a commit that referenced this pull request Jul 30, 2026
Wave 39 (#403) landed after this branch was cut and now requires a generated
root-policy pointer at every governed project, so add
packages/helpers/air-gap/AGENTS.md and bump the scoped-pointer count to 44.

Also clears the ten new SonarCloud findings the zero-findings gate reported:

- S8786 in src/base64url.ts and tests/helpers.ts — `=+$` backtracks
  super-linearly on a long run of '='. btoa pads to a multiple of four, so a
  bounded `={0,2}$` strips the same padding in linear time.
- S7749 in src/constants.ts — uneven numeric separator groups in
  `0x1_0000_0000`; `2 ** 32` states the u32 bound directly.
- S5906 across four test files — `toHaveLength` reports better than comparing
  a raw `.length`.

No behavior change: the frozen conformance vectors and all 100 tests pass
unchanged, src coverage stays at 100%, and the mutation score is 89.77%.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant