Add support to go directly to URL before API call#88
Merged
bswinnerton merged 2 commits intomasterfrom Oct 29, 2017
Merged
Conversation
As reported in #87, if you type the repository that you would like to go to without waiting for the GitHub API to respond, <kbd>⌘</kbd> + <kbd>Enter</kbd> does not work. This commit adds support to use <kbd>⌘</kbd> + <kbd>Enter</kbd> to go directly to the repository before triggering an API call to fetch all of the account's repositories.
bswinnerton
changed the title
Owner
Author
|
👋 @jasonrudolph, this should resolve your comment in #8 (comment) (and by relation, #87). Unfortunately there's a catch 😕. The order of repositories that comes back from the GitHub API doesn't take into account the exact search term. So if you hit ⌘ + Enter immediately after the repositories are shown in LaunchBar, you'll need to navigate down to your entry before hitting ⌘ + Enter. I've opened #89 to explore ways of reordering the list of repositories so this doesn't happen. |
Owner
Author
I've resolved said catch in #90 😄. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #87, if you type the repository that you would like to go to without waiting for the GitHub API to respond, ⌘ + Enter does not work.
This commit adds support to use ⌘ + Enter to go directly to the repository before triggering an API call to fetch all of the account's repositories.
This is a little easier to review using GitHub's
?w=1featureResolves #87.