Ember 6 Compat: Remove "action", Change to Class Style#74
Closed
ladadeedee wants to merge 2 commits intobtecu:masterfrom
Closed
Ember 6 Compat: Remove "action", Change to Class Style#74ladadeedee wants to merge 2 commits intobtecu:masterfrom
ladadeedee wants to merge 2 commits intobtecu:masterfrom
Conversation
aluink
reviewed
Mar 31, 2025
| super.didReceiveAttrs(...arguments); | ||
|
|
||
| // Tree built in extended component | ||
| let groups = this.get('list'); |
Contributor
Author
There was a problem hiding this comment.
We can change a lot of these this.get() calls but I don't want to cause too much change in this PR. this.set() is most likely off-limits until we move to Glimmer.
Owner
|
Excellent work @ladadeedee! Would it be possible to separate some of the smaller changes into different pull requests? The one concern I have is about |
This was referenced Apr 28, 2025
Contributor
Author
|
Once you finish your cleanup, I'll rebase (painfully) and see where we stand. |
Contributor
Author
|
We've manually applied pretty much all of the changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember 6 removes support for "action" helper in templates officially, after a long period of deprecation. https://deprecations.emberjs.com/id/template-action/
This PR does two big things and a few minor things:
actionin templates with either direct references orfnhelper if currying is neededhandleMouseEntercode onselect-dropdown-option, simplifying codeoninputbinding on theinputelement since there was an issue with the order of events fired. Its functionality was moved into the existingkeypresshandler. This required a minor workaround since theinputelement'svalueis not updated until after the key has been handled, requiring us to concat the current value plus the newly-entered keyblur()dropdownhandler due to a conflict between the passed-in value (a string, to specify custom dropdown component) and a functionselectfrom being passed to the dropdown component due to naming conflicts. Useparent.selectinsteadBasic, functionality appears to be working. I'm opening this as a draft to gather feedback.