Conversation
ladadeedee
approved these changes
Apr 29, 2025
| shouldFilter=this.shouldFilter | ||
| onSelect=(action "select") | ||
| }} | ||
| <this.dropdown |
Contributor
There was a problem hiding this comment.
This won't work with the current use of passing in strings, so it's a breaking change. Just want to call that out. This will be worthy of a version bump therefore.
Long-term, what do you think about passing in a block?
Owner
Author
There was a problem hiding this comment.
Agree, although the documentation was already specifying component and not string.
Yes, updating to @glimmer/component & using blocks here would be really nice and it would cleanup a bit the intertwined components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates main component to use class syntax.
Part of #74 + fixes.