Skip to content

Fix CI lint: update golangci-lint-action to v7 and clear all findings#1

Merged
bthall merged 2 commits into
mainfrom
fix/ci-lint
Jul 6, 2026
Merged

Fix CI lint: update golangci-lint-action to v7 and clear all findings#1
bthall merged 2 commits into
mainfrom
fix/ci-lint

Conversation

@bthall

@bthall bthall commented Jul 6, 2026

Copy link
Copy Markdown
Owner

The lint job has failed at setup on every push: the v2-format .golangci.yml requires golangci-lint v2, which golangci-lint-action@v6 refuses to install. Bumping to v7 makes lint actually run — and this also clears the 24 findings it then reports:

  • errcheck: exclude fmt.Fprint* (CLI writes to stdout; failures are unactionable), explicitly ignore read-only file closes, return the yaml encoder's Close error (it flushes)
  • gocritic: run main logic in run() so deferred cleanup executes before os.Exit
  • gosec: create the config directory 0o700 instead of 0o755
  • staticcheck ST1005: strip trailing punctuation from two error strings
  • misspell: cancelled -> canceled in comments
  • unused: drop connectTemplate, superseded by hostPaneOptsFor
  • gofmt: realign validArrangeLayouts

Verified locally with golangci-lint v2.0.2: 0 issues on this branch.

Brandon Hall added 2 commits July 6, 2026 15:44
The v2-format .golangci.yml requires golangci-lint v2, which action v6
refuses to install — the lint job has failed at setup on every push.
- errcheck: exclude fmt.Fprint* (CLI writes to stdout; failures are
  unactionable), explicitly ignore read-only file closes, and return the
  yaml encoder's Close error (it flushes)
- gocritic: run main logic in run() so deferred cleanup executes before
  os.Exit
- gosec: create the config directory 0o700 instead of 0o755
- staticcheck ST1005: strip trailing punctuation from two error strings
- misspell: cancelled -> canceled in comments
- unused: drop connectTemplate, superseded by hostPaneOptsFor
- gofmt: realign validArrangeLayouts
@bthall bthall merged commit 79c2e10 into main Jul 6, 2026
5 checks passed
@bthall bthall deleted the fix/ci-lint branch July 6, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant