Fix CI lint: update golangci-lint-action to v7 and clear all findings#1
Merged
Conversation
added 2 commits
July 6, 2026 15:44
The v2-format .golangci.yml requires golangci-lint v2, which action v6 refuses to install — the lint job has failed at setup on every push.
- errcheck: exclude fmt.Fprint* (CLI writes to stdout; failures are unactionable), explicitly ignore read-only file closes, and return the yaml encoder's Close error (it flushes) - gocritic: run main logic in run() so deferred cleanup executes before os.Exit - gosec: create the config directory 0o700 instead of 0o755 - staticcheck ST1005: strip trailing punctuation from two error strings - misspell: cancelled -> canceled in comments - unused: drop connectTemplate, superseded by hostPaneOptsFor - gofmt: realign validArrangeLayouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint job has failed at setup on every push: the v2-format .golangci.yml requires golangci-lint v2, which golangci-lint-action@v6 refuses to install. Bumping to v7 makes lint actually run — and this also clears the 24 findings it then reports:
Verified locally with golangci-lint v2.0.2: 0 issues on this branch.