Revert junit-jupiter v6 bump in JDK8-pinned modules#902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolutionStrategy.forcepins onorg.junit.jupiter:junit-jupiter(btrace-agent, btrace-gradle-plugin, integration-tests) from JDK8-compatible versions (5.14.4 / 5.11.4) to v6.1.2.develop'sbuildjob since the merge (Could not resolve org.junit.jupiter:junit-jupiter:6.1.1 ... only compatible with JVM runtime version 17 or newer), and it merged in the first place becausedevelophas no required status checks configured, so Renovate's automerge never actually waited for CI.Fix
Straight revert of #871 — restores the three pins to their JDK8-compatible versions. Verified
:btrace-agent:compileTestJavaand:integration-tests:compileTestJavaboth succeed locally.Test plan
./gradlew :btrace-agent:compileTestJava :integration-tests:compileTestJava— BUILD SUCCESSFULSeparately, I'm adding required status checks to
develop's branch protection so this class of break can't merge again regardless of Renovate's automerge settings.This change is