Skip to content

ci: adopt shared @btravstack reusable CI + release workflows - #62

Merged
btravers merged 3 commits into
mainfrom
ci/use-reusable-workflows
Jul 24, 2026
Merged

ci: adopt shared @btravstack reusable CI + release workflows#62
btravers merged 3 commits into
mainfrom
ci/use-reusable-workflows

Conversation

@btravers

Copy link
Copy Markdown
Contributor

Migrate CI and release to the shared reusable workflows in btravstack/config (the proven pattern already green in unthrown).

CI (.github/workflows/ci.yml)

Replaces the common per-job gate (format, lint, typecheck, test, build, security-audit, changeset) with a single call to ci-reusable.yml@main:

  • changeset: true
  • knip: false — the knip job has a bespoke pre-step (Prisma client generation), so it stays a repo-local job.
  • test-command: "pnpm test -- --coverage --reporter=default --reporter=github-actions"

Bespoke jobs kept (unchanged steps, needs: ci)

  • knip — keeps the Prisma-client-generate pre-step
  • bundle-size
  • package-check
  • node-floor (Node 22 engine floor)

Notes

  • Coverage artifact upload dropped. The old test job uploaded a coverage-report artifact; the reusable workflow runs the coverage command but does not export the artifact. Coverage still runs and gates via test-command.
  • Dropped the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env (the reusable workflows pin their own action versions; matches the proven unthrown setup).

Release (.github/workflows/release.yml)

Replaced with a call to release-reusable.yml@main, passing RELEASE_PAT. The reusable defaults (pnpm run version / pnpm run release) match demesne's prior config, so no input overrides are needed.

deploy-docs.yml and .github/actions/setup left untouched.

Copilot AI review requested due to automatic review settings July 24, 2026 08:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates demesne’s CI and release pipelines to shared reusable workflows in btravstack/config, reducing repo-local workflow maintenance while keeping a few bespoke CI jobs (knip, bundle-size, package-check, node-floor).

Changes:

  • Replaced the per-job CI gates with a single ci job that calls ci-reusable.yml, and wired bespoke jobs to depend on it.
  • Replaced the repo-local release job implementation with a call to release-reusable.yml, passing RELEASE_PAT.
  • Dropped the old coverage artifact upload and removed the now-unneeded FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/ci.yml Switches CI to a reusable workflow and keeps bespoke jobs gated on the reusable ci job.
.github/workflows/release.yml Switches Release to a reusable workflow call and passes RELEASE_PAT.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml Outdated
# OIDC token minted via `id-token: write`. Each package must have a
# Trusted Publisher configured on npmjs.com pointing at this repo +
# workflow file (.github/workflows/release.yml).
uses: btravstack/config/.github/workflows/release-reusable.yml@main

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned to @workflows-v1.

Comment thread .github/workflows/ci.yml Outdated
Comment on lines +16 to +17
ci:
uses: btravstack/config/.github/workflows/ci-reusable.yml@main

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned to @workflows-v1.

Comment thread .github/workflows/ci.yml Outdated
@btravers
btravers merged commit 596470f into main Jul 24, 2026
12 checks passed
@btravers
btravers deleted the ci/use-reusable-workflows branch July 24, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants