When updating the tests for the function responsive_is_bu_domain it was asked if the function caught all of the BU domains.
Who can confirm the list of sites and subdomains that need to get the Boston University copyright meta value?
Would it better to create a gets_bu_branding() function to separate specific use cases?
See PR #97 for the changes to the Test and the full conversation.
See a listing of domains/networks
Conversation Excerpt
Currently the function is only looking for bu.edu in the URL
|
function responsive_is_bu_domain() { |
|
return (bool) preg_match( '#\bbu\.edu\b#', network_home_url() ); |
|
} |
The functions only current use is to add a meta value with the Boston University name and Copyright. With branding guidelines do we want sites.bu.edu to get the BU Copyright key? Also, do we want agganisarena.com, citycoboston.com to get this copyright meta value? What about blogs.bu.edu?
|
<?php if ( responsive_is_bu_domain() ) : ?> |
|
<meta name="copyright" content="© <?php echo esc_attr( date( 'Y' ) ); ?> Boston University" /> |
|
<?php else : ?> |
|
<link rel="shortcut icon" href="<?php bloginfo( 'template_directory' ); ?>/icons/favicon-g.ico" /> |
|
<?php endif; ?> |
When updating the tests for the function
responsive_is_bu_domainit was asked if the function caught all of the BU domains.Who can confirm the list of sites and subdomains that need to get the Boston University copyright meta value?
Would it better to create a gets_bu_branding() function to separate specific use cases?
See PR #97 for the changes to the Test and the full conversation.
See a listing of domains/networks
Conversation Excerpt
Currently the function is only looking for bu.edu in the URL
responsive-framework/inc/template-tags.php
Lines 179 to 181 in 1f5a8ae
The functions only current use is to add a meta value with the Boston University name and Copyright. With branding guidelines do we want sites.bu.edu to get the BU Copyright key? Also, do we want agganisarena.com, citycoboston.com to get this copyright meta value? What about blogs.bu.edu?
responsive-framework/header.php
Lines 28 to 32 in 7f92fb4