PHP Unit Testing Updates by alektrefi · Pull Request #97 · bu-ist/responsive-framework

alektrefi · 2018-10-02T18:32:25Z

Update Travis version of WordPress Test to match our current version.
Update is_responsive_bu_domain tests to use different test for multi vs single site.

[X] I've reviewed the contribution guidelines.
[X] I've updated CHANGELOG.MD with a brief explanation of the changes in this pull request in the unreleased section.
[X] My code follows BU Coding Standards.

…nt version. Remove test code related to older versions of WP. Update is_responsive_bu_domain tests to use different test for multi vs single site.

sr4136 · 2018-10-03T15:23:27Z

@@ -148,18 +148,39 @@ function test_responsive_is_bu_domain() {
 	 * Test that BU domains correctly match.
 	 */
 	function test_responsive_is_bu_domain_true() {


I always wondered if this truly the full list of subdomains we should check for (what about sites.bu.edu, sites-staging.bu.edu, ect.). Also do we need to worry about this catching domains like agganisarena.com, citycoboston.com, others?

This is a good question. My initial goal here was to get the broken test working again. I appreciate how having the Unit tests prompted this deeper follow up.

Currently the function is only looking for bu.edu in the URL

responsive-framework/inc/template-tags.php

Lines 179 to 181 in 1f5a8ae

function responsive_is_bu_domain() {

return (bool) preg_match( '#\bbu\.edu\b#', network_home_url() );

}

The functions only current use is to add a meta value with the Boston University name and Copyright. With branding guidelines do we want sites.bu.edu to get the BU Copyright key? Also, do we want agganisarena.com, citycoboston.com to get this copyright meta value? What about blogs.bu.edu?

responsive-framework/header.php

Lines 28 to 32 in 7f92fb4

<?php if ( responsive_is_bu_domain() ) : ?>

<meta name="copyright" content="© <?php echo esc_attr( date( 'Y' ) ); ?> Boston University" />

<?php else : ?>

<link rel="shortcut icon" href="<?php bloginfo( 'template_directory' ); ?>/icons/favicon-g.ico" />

<?php endif; ?>

If we do want these sites to get the copyright meta value, then we need to update the function and the test.

Who can confirm the list of sites and subdomains that need to get the Boston University copyright meta value?

As discussed in person, I opened an issue for the broader question. #110

Please approve so we can close this as is and fix the tests.

toddmilliken · 2018-10-25T19:50:45Z

This looks good to me also!

Just for more context: I had updated the responsive_is_bu_domain function inside inc/template-tags.php to resolve a fatal error that occured on single site installs when responsive framework was added. efe3113#diff-5915276465e785d5f7897d71685fca5f resolves PR #3

* develop: (1259 commits) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG Fix CHANGELOG nested ul indendation Fix multiple Code Climate issues on CHANGELOG Update CHANGELOG with bugfix notes Update CHANGELOG to use level 2 headings Bugfix: Prevent empty post title from rendering Bugfix: Fix typo in name of customizer filter version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump Temporarily remove the `r_remove_news_template` filter Move the `include` out of the `if` Update README.md ... # Conflicts: # CHANGELOG.md

* develop: (1254 commits) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump Temporarily remove the `r_remove_news_template` filter Move the `include` out of the `if` Update README.md add contributor Version Bump 2.0.1 Code Climate Revision 2 Code Climate Revision Hub Indicator Style Integration ...

* develop: (1255 commits) Migrate Open PR #418 from 1x-develop fix deprecated GF call (#107) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump Temporarily remove the `r_remove_news_template` filter Move the `include` out of the `if` Update README.md add contributor Version Bump 2.0.1 Code Climate Revision 2 Code Climate Revision ... # Conflicts: # languages/responsive-framework.pot

* develop: (1262 commits) Migrate Open PR #407 from 1x-develop Security Audit June 2018 (#106) Migrate Open PR #418 from 1x-develop fix deprecated GF call (#107) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG Fix CHANGELOG nested ul indendation Fix multiple Code Climate issues on CHANGELOG Update CHANGELOG with bugfix notes Update CHANGELOG to use level 2 headings Bugfix: Prevent empty post title from rendering Bugfix: Fix typo in name of customizer filter version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump ... # Conflicts: # CHANGELOG.md

alektrefi added 7 commits October 2, 2018 14:31

Update Travis version of WordPress Version to Test to match our curre…

cf5fcb7

…nt version. Remove test code related to older versions of WP. Update is_responsive_bu_domain tests to use different test for multi vs single site.

update change log

b8b3d0b

revert removal of code to test travis

b7cb157

modify version test

93b810a

restore to original

e36cbe9

new line at file end

9d94234

remove item from changelog

797956b

alektrefi requested review from briannehinchliffe, hirozed, sr4136 and toddmilliken October 3, 2018 12:42

sr4136 reviewed Oct 3, 2018

View reviewed changes

alektrefi mentioned this pull request Oct 25, 2018

Verify the full list of BU Domains that get Branding #110

Open

sr4136 approved these changes Oct 25, 2018

View reviewed changes

alektrefi added the Target Next Release label Nov 2, 2018

alektrefi added 2 commits November 6, 2018 14:30

update change log

f090330

alektrefi merged commit d7394a4 into develop Nov 6, 2018

alektrefi deleted the is-bu-domain-tests-update branch November 6, 2018 19:46

alektrefi removed the Target Next Release label Nov 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP Unit Testing Updates#97

PHP Unit Testing Updates#97
alektrefi merged 9 commits into
developfrom
is-bu-domain-tests-update

alektrefi commented Oct 2, 2018 •

edited

Loading

Uh oh!

sr4136 Oct 3, 2018

Uh oh!

alektrefi Oct 18, 2018 •

edited

Loading

Uh oh!

alektrefi Oct 25, 2018

Uh oh!

toddmilliken commented Oct 25, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	function responsive_is_bu_domain() {
	return (bool) preg_match( '#\bbu\.edu\b#', network_home_url() );
	}

	<?php if ( responsive_is_bu_domain() ) : ?>
	<meta name="copyright" content="© <?php echo esc_attr( date( 'Y' ) ); ?> Boston University" />
	<?php else : ?>
	<link rel="shortcut icon" href="<?php bloginfo( 'template_directory' ); ?>/icons/favicon-g.ico" />
	<?php endif; ?>

Conversation

alektrefi commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sr4136 Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

alektrefi Oct 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alektrefi Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

toddmilliken commented Oct 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alektrefi commented Oct 2, 2018 •

edited

Loading

alektrefi Oct 18, 2018 •

edited

Loading

toddmilliken commented Oct 25, 2018 •

edited

Loading