Migrate Open PR #418 from 1x-develop fix deprecated GF call#107
Merged
Conversation
Contributor
|
Hi @stonybrookweb, I believe this has already been handled here #99 |
alektrefi
changed the title
toddmilliken
approved these changes
Oct 25, 2018
* develop: (1254 commits) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump Temporarily remove the `r_remove_news_template` filter Move the `include` out of the `if` Update README.md add contributor Version Bump 2.0.1 Code Climate Revision 2 Code Climate Revision Hub Indicator Style Integration ...
alektrefi
added a commit
that referenced
this pull request
Nov 7, 2018
* develop: (1255 commits) Migrate Open PR #418 from 1x-develop fix deprecated GF call (#107) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump Temporarily remove the `r_remove_news_template` filter Move the `include` out of the `if` Update README.md add contributor Version Bump 2.0.1 Code Climate Revision 2 Code Climate Revision ... # Conflicts: # languages/responsive-framework.pot
alektrefi
added a commit
that referenced
this pull request
Nov 7, 2018
* develop: (1255 commits) Migrate Open PR #418 from 1x-develop fix deprecated GF call (#107) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump Temporarily remove the `r_remove_news_template` filter Move the `include` out of the `if` Update README.md add contributor Version Bump 2.0.1 Code Climate Revision 2 Code Climate Revision ... # Conflicts: # languages/responsive-framework.pot
alektrefi
added a commit
that referenced
this pull request
Nov 9, 2018
* develop: (1262 commits) Migrate Open PR #407 from 1x-develop Security Audit June 2018 (#106) Migrate Open PR #418 from 1x-develop fix deprecated GF call (#107) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG Fix CHANGELOG nested ul indendation Fix multiple Code Climate issues on CHANGELOG Update CHANGELOG with bugfix notes Update CHANGELOG to use level 2 headings Bugfix: Prevent empty post title from rendering Bugfix: Fix typo in name of customizer filter version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump ... # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates https://github.com/bu-ist/responsive-framework-1x/pull/418 for this 2x repo as part of migrate process.
Confirmed this fix has been merged into 1x and is currently live.
ashleykolodziej commented on Jun 19
Looks fine to me, just need to test. Out of curiosity, is this something that we can fix/deploy before the upgrade without harming anything?This will have to be applied to both 1.0 and 2.0 by the looks of it.
carlosesilva commented on Jun 19
This cannot be deployed beforehand unfortunately and yes it will have to be applied to both.
carlosesilva commented on Jun 19
Here is the line that says it is deprecated:
https://github.com/wp-premium/gravityforms/blob/2.2.6/gravityforms.php#L4948
ashleykolodziej commented on Jul 11
Looks 👌 but this pull request will update 2.0, and will have to be moved over to the new repo to be made live. Can you open another pull request off the responsive-framework-1x branch in this repo? That will get this fixed in 1x, which I think is the biggest issue at hand.