fix consumer group rewrite - #4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes consumer group topic rewriting by decoding and rewriting Kafka consumer group member blobs so that group subscriptions/assignments are rewritten consistently across JoinGroup, SyncGroup, and DescribeGroups flows.
Changes:
- Decode/encode consumer
JoinGroupprotocol metadata to prefix subscribed topics on requests and strip them for the leader on responses. - Decode/encode consumer
SyncGroupmember assignments to prefix topics on requests and strip them in responses back to members. - Extend
DescribeGroupsResponseOutto also strip prefixed topic names inside member subscription / assignment blobs; add focused unit tests for these cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rewrite/groups.go | Adds consumer-group blob decoding helpers and applies topic rewriting to JoinGroup/SyncGroup and DescribeGroups member blobs. |
| rewrite/groups_test.go | Adds helpers + new tests validating topic rewriting/stripping behavior for member metadata/assignments and non-consumer passthrough. |
| proxy/rewrite_groups.go | Ensures JoinGroup/SyncGroup responses are post-processed so clients see client-space topics in leader/member blobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.