Skip to content

feat: Phrase short sentence handling - #2

Merged
holgern merged 2 commits into
buchwandler:mainfrom
crumblecoding:phrase-short-sentence-handling
Jul 25, 2026
Merged

feat: Phrase short sentence handling#2
holgern merged 2 commits into
buchwandler:mainfrom
crumblecoding:phrase-short-sentence-handling

Conversation

@crumblecoding

Copy link
Copy Markdown
Contributor

Allow setting short sentence handling options via cli, including phrase short sentence handling.

This PR is the corresponding PR to buchwandler/pykokoro#4 and most details can be found there.

bug fix

Fixed #1

Extended Summary

  • Added note on short sentence handling to summary to advice users about the possibility to increase the threshold.
  • added used short sentence config to summary

CLI Extensions

  • removed --enable-short-sentence (since its the default and produces better results in most cases)
  • added --short-sentence TEXT, which allows for fine-grained configuration like "mode=phrase,selection=auto,max-tries=4,threshold=30"
  • added "--seed NUMBER" to set the random seed via cli, helps with testing and consistency, since randomized phrase mode uses the seed as well.

AI Usage Disclaimer

AI has been used to create most of the code in this PR, though, I have reviewed, tested and verified the results.
Code structure, cli arguments, and config structure were chosen by me, not the AI.

Use template phrases and energy-valley based cutting, guided by the timestamped model, to significantly improve annunciation of short phrases.
@holgern

holgern commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks a lot for this PR.

@holgern
holgern merged commit 26cbe3f into buchwandler:main Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable_short_sentence attribute error

2 participants