build!: bump MSRV to 1.96.0 and migrate assert! matches! to assert_matches! - #418
Merged
Conversation
…tches! Raise rust-version to unlock assert_matches!/debug_assert_matches! (stable since 1.96) and core::hint::cold_path() (stable since 1.95). Migrate 151 assert!(matches!(value, Pattern)) call sites across exarch-core src/tests to assert_matches! for clearer Debug-based failure diagnostics. 4 sites in formats/zip.rs stay as assert!(matches!(..)) because the scrutinee is not Debug; 7 sites in tests/property_tests.rs stay as prop_assert!(matches!(..)) since proptest has no assert_matches!-equivalent. Annotate the quota.rs OPT-C003 cold branches in QuotaTracker::record_file/record_file_checked with cold_path(). Update all MSRV references across CI, docs, and specs, including the previously stale NFR-010/SC-008 spec items. BREAKING CHANGE: minimum supported Rust version is now 1.96.0. Downstream consumers pinned to an older toolchain must upgrade before taking this release.
bug-ops
force-pushed
the
feat/401-msrv-bump-1-97
branch
from
August 2, 2026 16:30
b05666b to
18c7a53
Compare
bug-ops
enabled auto-merge (squash)
August 2, 2026 16:30
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-versionfrom 1.93.0 to 1.96.0 to unlockassert_matches!/debug_assert_matches!(stable since 1.96) andcore::hint::cold_path()(stable since 1.95). 1.96.0 is the actual minimum needed — the two APIs used don't require 1.97.assert!(matches!(value, Pattern))call sites inexarch-coresrc/tests toassert_matches!forDebug-based failure diagnostics. 4 sites informats/zip.rsstay asassert!(matches!(..))(scrutinee isn'tDebug); 7 sites intests/property_tests.rsstay asprop_assert!(matches!(..))(proptest has noassert_matches!equivalent).cold_path()to the OPT-C003 hot/cold-path branches inQuotaTracker::record_file/record_file_checked(security/quota.rs).Cargo.toml, CI,clippy.toml, READMEs,CONTRIBUTING.md, theexarch-cliskill doc, and 13 previously stale spec references (including two normative items, NFR-010/SC-008 inspecs/001-exarch-system/spec.md).CHANGELOG.mdupdated under[Unreleased]with aBREAKING:-flagged entry.Context
Closes #401
Issue #401 was filed as a
P4/backlog/researchfeasibility note estimating ~66 candidate call sites and recommending deferral rather than a dedicated PR. The scope here was explicitly confirmed before implementation. The real count of eligible sites turned out to be 151, not 66 — the original estimate undercounted multi-line-formattedassert!(...)/matches!(...)calls.Breaking change
Minimum supported Rust version is now 1.96.0 (previously 1.93.0). Downstream consumers on an older toolchain must upgrade before taking this release.
Test plan
cargo +nightly fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --workspace --all-features --exclude exarch-python --exclude exarch-node(966 passed)cargo test --doc --workspace --all-featuresfor exarch-core/exarch-cli/exarch-node (exarch-python doc-test hits a known pre-existing PyO3 linker issue in local sandboxes, unrelated to this change and untouched by it)RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-featuresfor exarch-core/exarch-cli/exarch-noderustup run 1.96.0 cargo check --workspace --all-features --tests --ignore-rust-version— confirms the code actually compiles on the new MSRV floorassert!(matches!(...))sites outside the two documented exceptions