chore(core): link TODO(critic) markers to tracked issues#148
Merged
Conversation
bug-ops
enabled auto-merge (squash)
July 9, 2026 16:47
github-actions
Bot
added
area: cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO(critic)markers left by feat(core): allow mcp.json to override connect/discover timeouts #136 withTODO(#N)references, matching the project's convention of linking deferred design decisions to a tracked issue.crates/mcp-cli/src/commands/common.rs:273now references expose connect/discover timeout flags for manual introspect #144 (expose connect/discover timeout flags for manual introspect)crates/mcp-core/src/command.rs:136now references revisit whether an infinite-timeout option is needed for connect/discover #145 (revisit whether an infinite-timeout option is needed)Closes #138
Test plan
grep -rn "TODO(critic)"across the repo returns zero matchescargo build --workspacecargo +nightly fmt --checkcargo +stable clippy --all-targets --all-features --workspace -- -D warningscargo nextest run --all-features --workspace --no-fail-fast(721 tests pass)cargo test --doc --all-features --workspace(187 doc-tests pass)