chore: document rationale for existing allow attributes#151
Merged
Conversation
github-actions
Bot
added
area: cli
Add a comment above each item-level #[allow(...)] explaining why the lint does not apply, per the CLAUDE.md requirement for new suppressions. Closes #147
bug-ops
enabled auto-merge (squash)
July 9, 2026 17:31
bug-ops
force-pushed
the
fix/147-allow-lint-justification
branch
from
July 9, 2026 17:31
65da489 to
305f3a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[allow(...)]attribute that lacked one, per theCLAUDE.mdrequirement that new suppressions be justified inlinecrates/mcp-skill/src/context.rs,crates/mcp-server/src/service.rs, andcrates/mcp-cli/src/commands/{introspect,skill,generate}.rscrates/mcp-core/src/error.rs:346intentionally left untouched (inside a#[test]fn, self-explanatory from context, out of scope per the issue)Test plan
cargo +nightly fmt --checkcargo +stable clippy --all-targets --all-features --workspace -- -D warningscargo nextest run --all-features --workspace --no-fail-fast(696 passed)cargo test --doc --all-features --workspace(all doctests pass)git diffconfirmed comment-only change (13 insertions, 0 deletions)Closes #147