chore(mcp-introspector): drop unused rmcp transport-child-process feature#152
Merged
Conversation
github-actions
Bot
added
crate: mcp-introspector
bug-ops
enabled auto-merge (squash)
July 9, 2026 17:37
…ture TokioChildProcess was replaced by a manually spawned stdio pair in Rewrite spawn_introspection_child to mutate the Command directly so the feature (and its transitive deps: process-wrap, nix, and several Windows-only crates) can be dropped entirely. Closes #146
bug-ops
force-pushed
the
fix/146-drop-unused-rmcp-feature
branch
from
July 9, 2026 17:38
f114f52 to
75aa247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transport-child-processfeature fromcrates/mcp-introspector/Cargo.toml;TokioChildProcesswas already replaced by a manually spawned stdio pair in fix: introspector lifecycle robustness (child-process kill, eviction TOCTOU) #142, and the only remaining user of the feature wasConfigureCommandExtspawn_introspection_childto mutate thetokio::process::Commanddirectly (same args/envs/cwd/stdio sequence, verified behaviorally identical) instead of chainingConfigureCommandExt::configure(...)process-wrap,nix,cfg_aliases, and several Windows-only transitive crates that were only pulled in by the removed featureTest plan
cargo build --workspace --all-featurescargo +nightly fmt --checkcargo +stable clippy --all-targets --all-features --workspace -- -D warningscargo nextest run --all-features --workspace --no-fail-fast(696 passed)cargo test --doc --all-features --workspaceConfigureCommandExt,TokioChildProcess, ortransport-child-processCloses #146