fix(core): deduplicate denied secret prompts in orchestration loop#1476
Merged
fix(core): deduplicate denied secret prompts in orchestration loop#1476
Conversation
…1455) After a timeout or user denial in `process_pending_secret_requests()`, the `(handle_id, secret_key)` pair is now tracked in a plan-scoped `HashSet`. Subsequent re-requests from the same sub-agent for the same key are auto-denied without re-prompting the user.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_pending_secret_requests()now accepts a plan-scopeddenied: &mut HashSet<(String, String)>tracking(handle_id, secret_key)pairs already denied in this plan executiondenied; subsequent re-requests from the same sub-agent for the same key are auto-denied with atracing::debug!log without re-prompting the user(handle_id, key)pairHashSetis local torun_scheduler_loop()and is dropped when the plan ends; new plans start freshTest plan
cargo nextest run --workspace --features full --lib --bins— 4917 passed)cargo clippy --workspace --features full -- -D warnings— cleancargo +nightly fmt --check— clean