fix(orchestration): prevent duplicate secret prompt after timeout denial#1477
Closed
fix(orchestration): prevent duplicate secret prompt after timeout denial#1477
Conversation
Track denied (handle_id, secret_key) pairs in Agent::denied_secrets for the duration of the current plan execution. When a sub-agent re-requests a secret that was already denied (timeout or explicit rejection), process_pending_secret_requests silently re-denies it without prompting the user again. The set is cleared at the start of each handle_plan_confirm so denials from a previous run do not carry over. Closes #1455
github-actions
bot
added
documentation
Owner
Author
|
Superseded by #1476. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(handle_id, secret_key)pairs denied during plan execution in a newAgent::denied_secretssetprocess_pending_secret_requestssilently re-denies it without prompting the user againhandle_plan_confirmso previous run denials do not carry overTest plan
cargo nextest run --workspace --features full --lib --bins)Closes #1455