feat(cli,memory): type agents fleet --status flag and add tracing span#4365
Merged
Conversation
github-actions
Bot
added
memory
Closes #4357, #4358 - Add FleetStatus wrapper enum with clap::ValueEnum in src/cli.rs to keep clap out of zeph-memory; convert to SessionStatus via From impl - Replace Option<String> with Option<FleetStatus> in AgentsCommand::Fleet; remove manual .parse::<SessionStatus>() from handle_fleet - Add #[tracing::instrument(name = "memory.fleet.update_status", ...)] to SqliteStore::update_agent_session_status, matching sibling methods
bug-ops
force-pushed
the
fleet-cli-tracing
branch
from
7e2ce23 to
b002a10
Compare
… tracing spans (#4364) Extract format_tokens(n: u64) -> String into zeph-common/src/text.rs, replacing three identical local implementations in fleet.rs, status.rs, and agents.rs. Closes #4359. Add #[tracing::instrument] to reconcile_stale_sessions and update_agent_session_status in agent_sessions.rs, matching the convention established by upsert_agent_session. Closes #4348.
github-actions
Bot
added
size/M
github-actions
Bot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FleetStatuswrapper enum with#[derive(clap::ValueEnum)]insrc/cli.rs; keepsclapout ofzeph-memory(library crate)Option<String>withOption<FleetStatus>inAgentsCommand::Fleet; remove manual.parse::<SessionStatus>()fromhandle_fleet#[tracing::instrument(name = "memory.fleet.update_status", skip_all, level = "debug", err)]toSqliteStore::update_agent_session_status, matching sibling methodsCloses #4357, #4358
Test plan
cargo nextest run --workspace --lib --bins— 9871 passedcargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— cleanzeph agents fleet --status active— clap validates at parse time, shows variants in--helpzeph agents fleet --status invalid— clap-level error with suggestions (no runtime panic)