refactor: add #[must_use] to public validate/scan functions across workspace#4974
Merged
Conversation
…rkspace Extends the #[must_use] sweep from PR #4939 to cover all remaining public validate-style functions that return non-() values. Annotated 15 functions across 9 crates: - zeph-config: VigilConfig::validate, Config::validate, two entry.rs validate() - zeph-skills: SkillRegistry::scan_loaded (body() skipped — Result already #[must_use]) - zeph-orchestration: DependencyGraph::validate, validate_verify_config - zeph-experiments: EvalCase::validate - zeph-common: MemoryConfig::validate - zeph-core: QualityConfig::validate - zeph-mcp: validate_command, validate_env - zeph-plugins: validate_url_scheme_ephemeral - zeph-tools: validate_sandbox_denied_domains, validate_domain_patterns Closes #4943, #4961, #4963
github-actions
Bot
added
documentation
bug-ops
enabled auto-merge (squash)
June 7, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
#[must_use]sweep from PR #4939 to cover all remaining public validate-style functions that return non-()values. Without this annotation, callers can silently discard validation errors with no compiler warning.15 functions annotated across 9 crates:
VigilConfig::validate()Result<(), ConfigError>Config::validate()Result<(), ConfigError>entry.rs validate()(×2)Result<(), ConfigError>SkillRegistry::scan_loaded()Vec<(String, ScanResult)>DependencyGraph::validate()Result<(), OrchestrationError>validate_verify_config()Result<(), _>EvalCase::validate()Result<(), EvalError>MemoryConfig::validate()Result<(), String>QualityConfig::validate()Result<(), QualityConfigError>validate_command()Result<(), _>validate_env()Result<(), _>validate_url_scheme_ephemeral()Result<(), _>validate_sandbox_denied_domains()Result<(), String>validate_domain_patterns()Result<(), String>Note:
SkillRegistry::body()(returningResult<&str, SkillError>) was intentionally skipped —Resultis already#[must_use]in Rust stdlib, and adding a bare#[must_use]attribute triggersclippy::double_must_useunder-D warnings.Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace -- -D warnings— 0 warningsRUSTFLAGS="-D warnings" cargo check --workspace --all-targets --features desktop,ide,server,chat,pdf,scheduler --locked— cleancargo nextest run --config-file .github/nextest.toml --workspace --lib --bins— 10657 passedRUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace --features "desktop,ide,server,chat,pdf,scheduler"— cleanCloses #4943
Closes #4961
Closes #4963