test(core): add fidelity provider wiring tests for #5037 and #5039#5042
Merged
Conversation
github-actions
Bot
added
rust
bug-ops
force-pushed
the
test-fidelity-provider-wiring
branch
from
June 7, 2026 18:33
aa14613 to
2dff158
Compare
Add three tests to agent::builder::tests covering apply_session_config fidelity provider wiring: - apply_session_config_wires_fidelity_providers: asserts both fidelity_semantic_provider and fidelity_compress_provider are Some for non-empty names, None for empty names, and None when fidelity_config is absent. - apply_session_config_fidelity_providers_none_when_not_configured: explicit standalone coverage for the fidelity_config: None path. - apply_session_config_wires_fidelity_providers_registry_lookup: verifies resolve_background_provider performs a registry lookup — registers an Ollama entry "named-test" in provider_pool, asserts the resolved provider is name()=="ollama" with the expected model, and confirms an unregistered name falls back to the Mock primary. Closes #5037, closes #5039
- Remove redundant apply_session_config_fidelity_providers_none_when_not_configured (exact duplicate of the absent-config sub-case already covered in the pre-existing apply_session_config_wires_fidelity_providers test from PR #5038) - Add fidelity_compress_provider fallback assertion in the unregistered-name branch of apply_session_config_wires_fidelity_providers_registry_lookup for symmetric coverage of both provider fields
bug-ops
force-pushed
the
test-fidelity-provider-wiring
branch
from
June 7, 2026 18:37
2dff158 to
d5c6fba
Compare
github-actions
Bot
added
tests
bug-ops
enabled auto-merge (squash)
June 7, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_session_config_wires_fidelity_providers(pre-existing, PR test(context): add fidelity provider wiring assertions in apply_session_config #5038): three-branch test covering Some-provider wiring, empty-name → None, and absentfidelity_config→ None; satisfies all paths from test: add unit test for CAM fidelity provider wiring in apply_session_config #5037.apply_session_config_wires_fidelity_providers_registry_lookup(new, closes test(context): add end-to-end registry resolution coverage for resolve_background_provider (fidelity providers) #5039): verifiesresolve_background_providerperforms a real registry lookup — registers an Ollama entry"named-test"inprovider_pool, assertsname() == "ollama"andmodel_identifier() == "llama3.2", and verifies that an unregistered name falls back to the Mock primary for bothfidelity_semantic_providerandfidelity_compress_provider.Closes #5037
Closes #5039
Test plan
cargo nextest run --config-file .github/nextest.toml -p zeph-core -E 'test(fidelity)'→ 2 passedcargo clippy -p zeph-core --all-targets -- -D warnings→ cleancargo +nightly fmt --check→ clean