fix: correct workspace license declaration to MIT OR Apache-2.0#5865
Merged
Conversation
github-actions
Bot
added
documentation
bug-ops
enabled auto-merge (squash)
July 10, 2026 14:00
bug-ops
force-pushed
the
fix/5855-license-mismatch-zeph-bench
branch
from
July 10, 2026 14:21
95735f6 to
89dba52
Compare
Cargo.toml's workspace.package.license was set to "MIT" while scripts/add-spdx-headers.sh has stamped "MIT OR Apache-2.0" onto every new source file since v0.12.0, and 1100+ existing files already carry that SPDX header. The manifest, README badges, and per-crate READMEs were the odd ones out, not the source headers. Add LICENSE-APACHE and align every README's license badge/section with the manifest. Closes #5855
bug-ops
force-pushed
the
fix/5855-license-mismatch-zeph-bench
branch
from
July 10, 2026 14:31
89dba52 to
3e920e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.toml's[workspace.package] licensefield was"MIT", inherited by every crate vialicense.workspace = true. This was the actual bug:scripts/add-spdx-headers.shand.github/scripts/add-spdx-headers.shhave stampedSPDX-License-Identifier: MIT OR Apache-2.0onto every new.rsfile since v0.12.0, and 1100+ existing source files across the workspace already carry that header —zeph-bench(the crate originally reported in license mismatch: workspace declares MIT, zeph-bench declares MIT OR Apache-2.0 #5855) was not the anomaly, the manifest was.licenseto"MIT OR Apache-2.0"and added the missingLICENSE-APACHEfile at the repo root.README.mdand all 31 crate READMEs whose license badge/section still said plainMIT(excludingzeph-bench, which already correctly saidMIT OR Apache-2.0) to match the corrected manifest.crates/zeph-benchitself is untouched — its original SPDX headers and README were already correct.Follow-up (out of scope here)
crates/zeph-worktree/src/(error.rs,git_runner.rs,handle.rs,manager.rs,sanitize.rs) still carry plain-MITSPDX headers whilezeph-worktree/src/lib.rssays dual — an internal inconsistency that predates this issue and is a different defect class (not the cross-file "which do I read" contradiction license mismatch: workspace declares MIT, zeph-bench declares MIT OR Apache-2.0 #5855 reported). Will file a separate follow-up issue.Test plan
cargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins— 12374 passed, 35 skippedRUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace --features "desktop,ide,server,chat,pdf,scheduler"cargo metadataconfirms all 33 workspace crates reportlicense: "MIT OR Apache-2.0".github/deny.tomllicense allowlist confirmed compatibleCloses #5855