fix(orchestration): validate idle-timeout wizard input, warn on inert idle_timeout_secs#6313
Merged
Merged
Conversation
github-actions
Bot
added
documentation
bug-ops
force-pushed
the
feat/issue-6303/timeout-validation-hint
branch
from
July 16, 2026 16:40
180ba85 to
3d1eccf
Compare
bug-ops
enabled auto-merge (squash)
July 16, 2026 17:05
bug-ops
force-pushed
the
feat/issue-6303/timeout-validation-hint
branch
2 times, most recently
from
July 16, 2026 17:16
626c46a to
3bad48c
Compare
… idle_timeout_secs The --init wizard silently dropped invalid idle-timeout input to None instead of re-prompting; the wizard now reuses the shared parse_optional_nonzero validator (extracted from worktree.rs) so invalid input triggers a re-prompt like other numeric fields. The config loader now rejects default_idle_timeout_secs == Some(0) for consistency with the worktree fields, and the scheduler emits a one-time warning when idle_timeout_secs is set anywhere (config or task-level) since the field is not yet enforced per spec-075. Closes #6303 Closes #6302
bug-ops
force-pushed
the
feat/issue-6303/timeout-validation-hint
branch
from
July 16, 2026 17:26
3bad48c to
0669bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--initwizard no longer silently drops invalid idle-timeout input toNone; it now reuses a sharedparse_optional_nonzerovalidator (extracted fromworktree.rs) so invalid input re-prompts, consistent with other numeric fields in the wizard.default_idle_timeout_secs == Some(0)for consistency with the worktree fields.tracing::warn!whenidle_timeout_secsis set anywhere (config-level or per-task) but not enforced, since the field remains a documented no-op in this release per spec-075.Both issues were flagged by impl-critic during review of #6243 (orchestration node control parity, spec-075) and deliberately deferred to keep that PR scoped.
Closes #6303
Closes #6302
Test plan
cargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins(13800 passed / 0 failed)RUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace ...)gitleaks protect --staged(0 leaks)Some(0)rejection, scheduler warn-once behavior for bothScheduler::new()andresume_from()zeph-config experiment::tests::orchestration_config_default_idle_timeout_secs_is_none,zeph-orchestration scheduler::tick::tests::test_idle_timeout_secs_is_a_no_op.local/testing/playbooks/orchestration.mdand.local/testing/coverage-status.mdupdated (main repo path)