Skip to content

test(core): cover build_user_message vision-capability gate#6438

Merged
bug-ops merged 1 commit into
mainfrom
feat/issue-6412/build-user-message-vision-capa
Jul 18, 2026
Merged

test(core): cover build_user_message vision-capability gate#6438
bug-ops merged 1 commit into
mainfrom
feat/issue-6412/build-user-message-vision-capa

Conversation

@bug-ops

@bug-ops bug-ops commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds direct unit test coverage for build_user_message's LlmProvider::supports_vision() branch, mirroring the existing emit_media_parts test pair used for the sibling MCP-media-passthrough gate.
  • Test-only change; no production code modified.

Closes #6412

Test plan

  • cargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins — 14290 passed, 0 failed (includes both new tests)
  • cargo +nightly fmt --check
  • cargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warnings
  • RUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace --features "desktop,ide,server,chat,pdf,scheduler"
  • gitleaks protect --staged

Adds direct unit test coverage for build_user_message's
supports_vision() branch, mirroring the existing emit_media_parts
test pair for the sibling MCP-media-passthrough gate.

Closes #6412
@github-actions github-actions Bot added documentation Improvements or additions to documentation rust Rust code changes core zeph-core crate tests Test-related changes size/M Medium PR (51-200 lines) labels Jul 18, 2026
@bug-ops
bug-ops enabled auto-merge (squash) July 18, 2026 02:01
@bug-ops
bug-ops merged commit c936cb2 into main Jul 18, 2026
43 checks passed
@bug-ops
bug-ops deleted the feat/issue-6412/build-user-message-vision-capa branch July 18, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core zeph-core crate documentation Improvements or additions to documentation rust Rust code changes size/M Medium PR (51-200 lines) tests Test-related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build_user_message vision-capability gate lacks direct test coverage

1 participant