fix(cli,vault): honor --vault-key/--vault-path overrides in registry token resolution#6610
Merged
Conversation
github-actions
Bot
added
bug
bug-ops
enabled auto-merge (squash)
July 20, 2026 20:08
bug-ops
force-pushed
the
fix/6591-registry-vault-override
branch
from
July 20, 2026 20:16
446b400 to
7f0bff0
Compare
bug-ops
force-pushed
the
fix/6591-registry-vault-override
branch
from
July 20, 2026 20:16
7f0bff0 to
04a2496
Compare
…token resolution resolve_registry_token hardcoded default_vault_dir() for the Age vault backend, ignoring --vault/--vault-key/--vault-path CLI overrides already respected by every sibling vault-backed CLI path (durable.rs, scheduler_daemon.rs, per #6590). zeph skill/plugin search and get now thread the same overrides through handle_skill_command/handle_plugin_command into resolve_registry_token via bootstrap::resolve_vault_paths, so registry auth resolves against the same vault as the rest of the command. Closes #6591
The vault-override threading in the prior commit pushed registry_get (src/commands/skill.rs) to 8 parameters, exceeding clippy's default too_many_arguments threshold under the `registry` feature. Only the CI job's full feature set (which includes `registry`) exercises this function; the feature list documented locally in CLAUDE.md/branching.md omits it, so no local check caught this before push.
bug-ops
force-pushed
the
fix/6591-registry-vault-override
branch
from
July 20, 2026 20:27
04a2496 to
8e556b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_registry_token(src/commands/registry_client.rs) hardcodeddefault_vault_dir()for theAgevault backend, ignoring--vault/--vault-key/--vault-pathCLI overrides already respected by every sibling vault-backed CLI path (durable.rs,scheduler_daemon.rs, per fix(bootstrap,durable): resolve vault CLI overrides across all key-material call sites #6590).vault_override/vault_key_override/vault_path_overridefromrunner.rs's CLI dispatch throughhandle_skill_command/registry_search/registry_get(src/commands/skill.rs) andhandle_plugin_command/registry_search/registry_get(src/commands/plugin.rs) intoresolve_registry_token, which now resolves the vault key/secrets paths viacrate::bootstrap::resolve_vault_pathsinstead of the hardcoded default.registry_client.rs) proving the override path is actually read from, with a companion test confirming the no-override fallback behavior is unchanged.#[allow(clippy::too_many_lines)]tohandle_plugin_command, which crossed the threshold after the parameter growth (mirrors the existing allow already onhandle_skill_command).Closes #6591
Test plan
cargo build --features fullcargo nextest run --config-file .github/nextest.toml -p zeph --features full— 1136 passed, 15 skipped, 0 failedcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warnings— cleancargo +nightly fmt --check— cleangitleaks protect --staged --no-banner --redact— no leaksdefault_vault_dir()verified viaXDG_CONFIG_HOME-scoped tempdir isolation,#[serial_test::serial])