refactor(core): remove legacy #[cfg(test)]-only dispatch harness duplicating production tool/LLM dispatch#6617
Merged
Merged
Conversation
bug-ops
enabled auto-merge (squash)
July 20, 2026 21:31
bug-ops
force-pushed
the
fix/6560-legacy-dispatch-harness
branch
2 times, most recently
from
July 20, 2026 21:50
6b7e00c to
ff9c948
Compare
…icating production tool/LLM dispatch The tool_result.rs and llm_dispatch.rs legacy sequential-dispatch harnesses were kept alive only by their own tests, reimplementing the classify -> summarize -> sanitize -> persist pipeline already owned by process_one_tool_result/call_chat_with_tools_retry. This divergence previously masked a real production gap (issue #6364). All dependent tests are repointed to exercise the real production entry points, and both dead harnesses (~500 lines total) are removed. Closes #6560
bug-ops
force-pushed
the
fix/6560-legacy-dispatch-harness
branch
from
July 20, 2026 22:01
ff9c948 to
a9c4dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg(test)]-only legacy sequential-dispatch harness incrates/zeph-core/src/agent/tool_execution/tool_result.rs(handle_tool_result,record_tool_output_outcome,process_successful_tool_output,handle_confirmation_required), superseded in production byprocess_one_tool_result/handle_confirmation_phase(tier_loop.rs)crates/zeph-core/src/agent/tool_execution/llm_dispatch.rs(call_llm_with_timeout,call_llm_non_streaming,call_llm_with_retry), superseded bycall_chat_with_tools_retry/call_chat_with_tools/dispatch_chat_with_tools/call_non_streamingTest plan
cargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins— 15006 passed, 0 failed, 36 skippedRUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links")gitleaks protect --staged#[cfg(test)]-gated code)Closes #6560