test: assert OOB Set is retrieved at the last index - #290
Open
official-burak wants to merge 1 commit into
Open
Conversation
The oracle asked Get for the original out-of-range path after Set, which fails because those writes append at the end.
Owner
|
Thanks for the contribution, will validate asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the clear report in #288. The oracle was calling Get with the original out-of-range index after Set, but those writes append at the end, so
[1,2]plus[5]becomes[1,2,9]and the value lives at[2].I pointed the regression cases at that append-at-end document and at Get on the new last index, including the nested case that was still marked as an open data-loss bug.
Fixes #288