Skip to content

Comments

convert @bugsnag/core/lib/clone-client to TypeScript#2394

Merged
gingerbenw merged 13 commits intointegration/typescriptfrom
PLAT-13703-clone-client
Apr 9, 2025
Merged

convert @bugsnag/core/lib/clone-client to TypeScript#2394
gingerbenw merged 13 commits intointegration/typescriptfrom
PLAT-13703-clone-client

Conversation

@AnastasiiaSvietlova
Copy link
Contributor

@AnastasiiaSvietlova AnastasiiaSvietlova commented Mar 28, 2025

Goal

Convert @bugsnag/core/lib/clone-client to TypeScript

This PR also resolves an issue in the node end to end tests where the latest version of @bugsnag/core was installed from npm, rather than the monorepo.

RN 0.78 iOS test is failing due to a separate issue and is out of the scope of this PR

Testing

Covered by existing end to end and unit tests

@AnastasiiaSvietlova AnastasiiaSvietlova marked this pull request as ready for review April 1, 2025 09:38
@gingerbenw gingerbenw force-pushed the PLAT-13703-clone-client branch from 50379b5 to efb4967 Compare April 1, 2025 12:42
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 56.68 kB 17.24 kB
After 56.74 kB 17.25 kB
± ⚠️ +60 bytes ⚠️ +11 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 049691b

@gingerbenw gingerbenw force-pushed the PLAT-13703-clone-client branch from 6d839ef to cd2469e Compare April 1, 2025 16:30
@gingerbenw gingerbenw requested a review from lemnik April 2, 2025 08:54
@gingerbenw gingerbenw requested a review from hamudi-ahmed April 8, 2025 14:05
Copy link
Contributor

@hamudi-ahmed hamudi-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gingerbenw gingerbenw merged commit 04b5760 into integration/typescript Apr 9, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants