Skip to content

Fixed linting issues #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Cawllec merged 1 commit into from
Nov 2, 2017
Merged

Fixed linting issues #131

Cawllec merged 1 commit into from
Nov 2, 2017

Conversation

@Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Nov 1, 2017

After Flake8 updates the linter picked up issues with no Exception types being defined on excepts.

To remedy this:

  • Named errors were used where appropriate in tests (ImportError and ScaryException)
  • Generic excepts were given "Exception" to avoid changing functionality

@Cawllec Cawllec merged commit 02fd446 into master Nov 2, 2017
@kattrali kattrali deleted the cawllec/fix-lint-issues branch August 27, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kylef kylef kylef approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cawllec @kylef