Skip to content

Issue3562#2272

Merged
rutsky merged 5 commits intobuildbot:masterfrom
paidhi:issue3562
Jun 15, 2016
Merged

Issue3562#2272
rutsky merged 5 commits intobuildbot:masterfrom
paidhi:issue3562

Conversation

@paidhi
Copy link
Copy Markdown
Contributor

@paidhi paidhi commented Jun 12, 2016

@mention-bot
Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @tardyp, @djmitche and @gracinet to be potential reviewers

1 similar comment
@mention-bot
Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @tardyp, @djmitche and @gracinet to be potential reviewers

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 12, 2016

Current coverage is 84.23%

Merging #2272 into master will increase coverage by <.01%

  1. File .../changes/hgpoller.py was modified. more
    • Misses -1
    • Hits +1
@@             master      #2272   diff @@
==========================================
  Files           359        359          
  Lines         34428      34428          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          28999      29000     +1   
+ Misses         5429       5428     -1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by a4ec098...0706249

@tardyp
Copy link
Copy Markdown
Member

tardyp commented Jun 12, 2016

looks good! thanks

@rutsky
Copy link
Copy Markdown
Member

rutsky commented Jun 12, 2016

@paidhi LGTM, thanks! Can you add short record in changelog with fixed issue description and reference to 3562 ticket?

@paidhi
Copy link
Copy Markdown
Contributor Author

paidhi commented Jun 13, 2016

I'm not sure what my last commit (8a37eaf) could have done to break the build step.
Can you have a look?

@tardyp
Copy link
Copy Markdown
Member

tardyp commented Jun 13, 2016

paidhi. its a problem with last version of sphinx
you can cherry-pick this, which is in my current PR

2c7ca92

@tardyp
Copy link
Copy Markdown
Member

tardyp commented Jun 13, 2016

looks good

@rutsky rutsky merged commit 32d7385 into buildbot:master Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace client.getPage() with

5 participants