feat(cli): Add PR/issue attachments with stable URLs to the uploads CLI#8
Merged
Zach Dunn (zachdunn) merged 12 commits intoJul 7, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…Hub attachments branch
Zach Dunn (zachdunn)
added a commit
that referenced
this pull request
Jul 7, 2026
Resolve conflicts in CLI exports and commands from #8 (GitHub attachments). Fix no-array-sort in github.ts, extend CI to run uploads package tests, and add uploads/test to oxlint overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GitHub PR/issue attachments to the
@buildinternet/uploadsCLI. No API changes — the server already supports everything via?prefix=listing.What's new
uploads put <file> --pr <num>/--issue <num>— uploads to a deterministic key:gh/<owner>/<repo>/pull/<num>/<filename>(no content hash, unlike the screenshot key scheme). Same filename → same key → same URL, so re-uploading a file updates every place the URL is already embedded on GitHub. Repo is inferred from the git remote (gh repo view, falling back to parsingorigin);--repo owner/nameoverrides.uploads comment --pr <num>(andput … --comment) — creates or updates a single managed "📎 Attachments" comment on the PR/issue through the user's localghauth. It finds its own prior comment via a hidden marker (<!-- uploads.sh:attachments -->) and edits it in place; it never touches other comments or the description. Onput --comment,ghfailures degrade to a warning — the upload never fails because GitHub is unreachable.uploads list --pr <num>/--issue <num>— prefix-translated listing of a PR/issue's attachments.CommandRunner(alwaysexecFileSyncwith arg arrays; comment bodies via stdin), so theghinteraction is unit-tested without network.Design docs
docs/superpowers/specs/2026-07-07-github-companion-design.md(includes compatibility notes with the parallel shared-bucket workspace-prefix work — the two compose without changes to either)docs/superpowers/plans/2026-07-07-github-companion-v1.mdVerification
Live end-to-end against production (workspace
default, scratch PR #7, since closed): upload → embed → re-upload same filename → URL served the new bytes;commentrun twice produced exactly one managed comment (created, then edited in place); withghhidden from PATH, the upload succeeded with a warning and exit 0. Evidence in the task reports under.superpowers/sdd/(not committed).Follow-ups (deferred)
buildinternet-skills(localb3a3b4a, not pushed) points thegithub-screenshotsskill at this CLI