Fix typo in environment variable name for allowed-plugins#2526
Merged
Conversation
Contributor
|
😨 I don't even know how that got through. I'm normally quite picky in self-review. 🤦 AFAIK, we (canva) are not using it yet. |
triarius
approved these changes
Dec 1, 2023
Contributor
Author
|
i'm going to explain away the breaking-ness of this change thusly: no one who used this environment variables (if indeed anyone has) will have used this and not said "wait, what? it's called |
DrJosh9000
approved these changes
Dec 4, 2023
DrJosh9000
left a comment
DrJosh9000
left a comment
Contributor
There was a problem hiding this comment.
Yeah, this is new enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i came across this when reviewing #2406 - i'm kind of shocked that this made it through review. i blame the reviewer (me).
sigh. this is technically a breaking change. what do we do about that?
cc/ @jakubm-canva @david-poirier