Use os.RemoveAll in cleanup#2538
Merged
Merged
Conversation
triarius
approved these changes
Dec 4, 2023
Because the tests are parallel, using the same directory would cause flakes. So also use a different directory for each test.
Co-authored-by: Narthana Epa <narthana.epa@gmail.com>
DrJosh9000
force-pushed
the
tempfile-test-cleanup-removeall
branch
from
December 4, 2023 23:21
26939c2 to
aff59a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the tests are parallel, using the same directory would cause flakes. So also use a different directory for each test.