Add development environment setup instructions - #4129
Conversation
There was a problem hiding this comment.
The new repository-wide instructions still rely on prepared-environment assumptions, and the end-to-end example does not reliably run the binary built from this checkout. I’ve marked both inline.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 9332, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
Co-authored-by: lachlan <lachlan@buildkite.com>
Co-authored-by: lachlan <lachlan@buildkite.com>
a9d3107 to
1d04401
Compare
There was a problem hiding this comment.
Both previous concerns remain open after this update; I didn’t find any new issues.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 9345, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
…-agent Co-authored-by: lachlan <lachlan@buildkite.com>
Previous concerns have been addressed.
There was a problem hiding this comment.
Both previous concerns are resolved; I found no new issues. I’m leaving this comment-only because AGENTS.md changes repository-wide executable setup instructions, which is above the default approval ceiling.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 9640, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
Co-authored-by: lachlan <lachlan@buildkite.com>
Previous concerns have been addressed.
There was a problem hiding this comment.
The previous concerns remain resolved after the consolidation, and I found no new issues. I’m leaving this comment-only because AGENTS.md is repository-wide executable guidance, which is above the default approval ceiling.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 9641, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
What
Consolidates the repo's agent/developer instructions into a single
AGENTS.mdand documents how to set up and run the development environment for the Buildkite Agent (a single Go CLI application). No product code is changed.AGENT.md(singular) is not a filename Cursor reads; Cursor picks upAGENTS.md(plural). To avoid two near-identically-named files,AGENT.md's "Build/Test/Lint Commands", "Architecture", and "Code Style" content is merged intoAGENTS.md, andAGENT.mdis deleted.## Development environment notessection capturing non-obvious setup/run caveats.The notes capture non-obvious setup/run caveats discovered while bringing up a clean environment:
mise install),golangci-lint(standalone binary pinned inmise.toml), andrubyfor polyglot hook tests.gofumpt/gotestsumare Gotools and need no separate install.internal/jobtestTestResolvingGitHostAliasesWithFlagSupportruns inside a container (/.dockerenv) and expects.buildkite/build/ssh.confat/etc/ssh/ssh_config.d/(mirroring.buildkite/Dockerfile-compile).internal/job/integration(TestPreExitHooksFireAfterCancel); warm the cache first../buildkite-agent bootstrap(no Buildkite token required).Environment verified
go build -o buildkite-agent .--version=3.134.0go tool gofumpt -extra -l .+golangci-lint rungo tool gotestsum -- ./..../buildkite-agent bootstrap ... --phases commandHello world (core functionality —
bootstrapruns a job locally):