feat: Populate on-host mirrors from remote mirrors - #4161
Conversation
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
I didn't find a concrete issue to flag inline. The change reaches the shared mirror clone/update and atomic-publication paths, so this still needs a human sanity-check.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10735, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
|
Propagated the parent plan correction in merge |
There was a problem hiding this comment.
The remote-hit early return needs to preserve the existing origin-reconciliation path; details inline.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10796, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
|
Merged foundation review fixes through |
|
Added the red-step regressions in |
|
Fixed the on-host review issue in |
|
Follow-up |
|
Propagated the recursive-submodule eligibility foundation through |
Previous concerns have been addressed.
There was a problem hiding this comment.
The previous origin-reconciliation concern is fixed. I found one new retry path that can leave a remote-fetched object unpinned; details inline.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10828, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
There was a problem hiding this comment.
The previous destination-ref retry concern is still open; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10839, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
|
Propagated the final plan alignment through |
There was a problem hiding this comment.
The destination-ref retry concern is still open; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10848, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
|
Added red-step contention and warm-cache regressions in |
|
Implemented the on-host re-review fixes in |
There was a problem hiding this comment.
The destination-ref retry concern is still open; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10852, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
There was a problem hiding this comment.
The merge updates only the parent documentation, so the destination-ref retry concern remains open. I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10862, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
There was a problem hiding this comment.
The destination-ref retry concern is still open because the regression’s second attempt does not match the production retry path. I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10869, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
|
Final on-host fix |
There was a problem hiding this comment.
The destination-ref retry concern remains open after this foundation merge; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10875, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
There was a problem hiding this comment.
The destination-ref retry concern is still open after this foundation merge; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10888, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
There was a problem hiding this comment.
The destination-ref retry concern is still open; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10892, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
|
@buildsworth-bk review @buildsworth-bk approve L2 |
There was a problem hiding this comment.
The destination-ref retry concern is still open after this foundation merge; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 10904, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
There was a problem hiding this comment.
The destination-ref retry concern is still open after the foundation merge; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 11124, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
There was a problem hiding this comment.
The previous destination-ref retry concern remains open; I found no new issues this pass.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 11261, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
Co-authored-by: Paul Annesley <pda@users.noreply.github.com>
d78865c to
039ec85
Compare
|
Rebased onto current |
Previous concerns have been addressed.
There was a problem hiding this comment.
The previous concern is fixed, and I found no new issues. This still needs human review because it changes shared mirror publication and checkout alternate handling.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 11278, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
Co-authored-by: Paul Annesley <pda@users.noreply.github.com>
|
Follow-up for the rewritten CI run: Windows correctly exposed that the new retry regression left the executor's |
Previous concerns have been addressed.
There was a problem hiding this comment.
The previous destination-ref retry concern remains fixed after this test-only cleanup, and I found no new issues. This still needs human review because it changes shared mirror publication and checkout alternate handling.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 11290, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
4 participants
Description
Populate and refresh the shared on-host mirror from the server-provided remote mirror before falling back to canonical. This is PR 2 based on #4160.
Context
The shared mirror’s durable
originand canonical heads remain canonical for mixed-version agents. Remote objects are pinned in a namespaced ref without moving canonical refs.Changes
origin, and atomically publish.--no-tagsand hidden URL prompts.originon remote and warm hits before shared rename maintenance.Testing
Real Git-over-HTTP tests cover atomic creation, permissions, staging, lag, timeout, namespaced refs, tag/head isolation, fallback, warm/remote collision repair, failed ref write plus canonical force-push plus reused-checkout retry, lock contention, prompt hiding, and cancellation. The retry regression verifies the stale alternate is removed before canonical fetch; test executors close checkout roots for Windows cleanup.
Disclosures / Credits
Implemented with Cursor under human direction. Independent review drove atomic publication, durable reachability, retry alternate cleanup, warm-hit maintenance, and contention fallback.