fix: Skip post-fetch mirror scan without URL - #4172
Merged
Merged
Conversation
Co-authored-by: Paul Annesley <pda@users.noreply.github.com>
cursor
Bot
force-pushed
the
pda/remote-mirror-no-url-post-fetch-c275
branch
from
August 4, 2026 09:07
ed7c062 to
d3c28fc
Compare
|
Rebased and force-pushed the hotfix as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first no-URL mirror hotfix restored the fast path only when the requested commit was already present. When a canonical fetch added a missing commit, checkout still ran the final global
for-each-ref --containssafety scan. On a production mirror that added another 3 minutes 15 seconds after a one-second fetch.Skip that final reachability scan for the same resolved
no-urlattempt state. The unpinned-object safeguard remains unchanged whenever a remote mirror URL is configured.Context
Changes
for-each-ref.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Focused warm-hit, post-fetch, URL-repair, and configured-remote retry regressions pass under the race detector.
Disclosures / Credits
Cursor Agent correlated the second production trace with the remaining code path, implemented the focused correction and regression coverage, and ran independent ship-risk, maintainability, and simplicity reviews.