SUP-1755 Add keybindings type #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jradtilbrook
force-pushed
the
sup-1755-create-a-type-for-keybindings
branch
4 times, most recently
from
22ac240 to
a5283a4
Compare
jradtilbrook
requested review from
james2791,
lizrabuya and
mcncl
as code owners
lizrabuya
approved these changes
Feb 5, 2024
jradtilbrook
force-pushed
the
sup-1755-create-a-type-for-keybindings
branch
from
a5283a4 to
ba6c600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new package is intended to be used by a list component for configuring actions when a user presses a key
It builds upon the idea of keymaps in the bubbles list model by adding the callback to execute when the key is pressed. It also implements an interface that makes it renderable by the bubbles help model as well so it will "just work" when we put it into another model