SUP-1761 Implement local config pipeline resolver func #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizrabuya
requested review from
PriyaSudip,
jradtilbrook and
mcncl
as code owners
Contributor
jradtilbrook
left a comment
jradtilbrook
left a comment
There was a problem hiding this comment.
I think looks good, but the order of the resolvers seems wrong. I think we want to use the config file before we try use the API
| resolvers := resolver.NewAggregateResolver( | ||
| resolver.ResolveFromPositionalArgument(args, 1, f.Config), | ||
| resolver.ResolveFromPath("", f.Config.Organization, f.RestAPIClient), | ||
| resolver.ResolveFromConfig(f.LocalConfig), |
Contributor
There was a problem hiding this comment.
I think we want these above the ResolveFromPath
Contributor
There was a problem hiding this comment.
Need to apply this to all the commands
Contributor
Author
There was a problem hiding this comment.
missed to save the other commands and didn't double check the commit 😓
Co-authored-by: Jarryd Tilbrook <jarryd@buildkite.com>
…nto local-config-resolver-fn
jradtilbrook
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a pipeline resolver function that searchers for a local config file .bk.yaml. When more than one pipelines are found in the local config, a selection list of pipelines will be prompted to the user
Not implemented in the PR:
Tests